Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ChangeFeedProcessor: Adds AllVersionsAndDeletes support to ChangeFeedProcessor#4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@philipthomas-MSFT
Copy link
Contributor

Pull Request Template

Description

AddingAllVersionsAndDeletes toChangeFeedProcessor.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@philipthomas-MSFTphilipthomas-MSFT requested a review froma team as acode ownerMarch 25, 2024 20:43
FabianMeiswinkel
FabianMeiswinkel previously approved these changesMar 26, 2024
Copy link
Member

@FabianMeiswinkelFabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Given the naming has been discussed before and was agreed-upon - LGTM

philipthomas-MSFT reacted with thumbs up emoji
@philipthomas-MSFT
Copy link
ContributorAuthor

Given the naming has been discussed before and was agreed-upon - LGTM

Much appreciated Fabian. I will make a note to bring other SDK and Principals in on these discussions if necessary moving forward.

@philipthomas-MSFT
Copy link
ContributorAuthor

philipthomas-MSFT commentedMar 26, 2024•
edited
Loading

Necessary to run these locally.

dotnet.exe build Microsoft.Azure.Cosmos.sln -p:Optimize=true -p:IsPreview=true;SdkProjectRef=truedotnet.exe build Microsoft.Azure.Cosmos.sln -p:Optimize=true -p:IsPreview=true

Both andMicrosoft.Azure.Cosmos.Encryption.EncryptionContainer andMicrosoft.Azure.Cosmos.Encryption.Custom.EncryptionContainer need#if SDKPROJECTREF.

Custom encryption container has throw new NotImplementedException.
Non-custom encryption container has actual implementation.

After build and merged, custom encryption container can have the actual implementation?

Copy link
Member

@FabianMeiswinkelFabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jcocchijcocchijcocchi left review comments

@ealsurealsurealsur approved these changes

@FabianMeiswinkelFabianMeiswinkelFabianMeiswinkel approved these changes

@kirankumarkollikirankumarkolliAwaiting requested review from kirankumarkollikirankumarkolli is a code owner

@kirillgkirillgAwaiting requested review from kirillg

@sboshrasboshraAwaiting requested review from sboshrasboshra is a code owner

Labels

auto-mergeEnables automation to merge PRsdilithium-semester

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@philipthomas-MSFT@ealsur@jcocchi@FabianMeiswinkel
[8]ページ先頭
©2009-2025 Movatter.jp