Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DisableServerCertificateValidation: Fixes Default HttpClient to honor DisableServerCertificateValidation#4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kirankumarkolli
Copy link
Member

@kirankumarkollikirankumarkolli commentedFeb 1, 2024•
edited
Loading

Description

WhenDisableServerCertificateValidation is set:
ServerCertificateCustomValidationCallback is conditionally set after validation when ConnectionPolicy is created. But HttpClient is created before ConnectionPolicy creation resulting in the configuration getting ignored.

changes

  • Make CosmosClientOptions.ServerCertificateCustomValidationCallback immutable post initialization.
    • New internal API GetServerCertificateCustomValidationCallback() which abstracts the certificate validation callback definition.
  • Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination
  • Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actionsgithub-actionsbot left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All good!

@kirankumarkollikirankumarkolli changed the titleDisableServerCertificateValidation: Fix ensuring that both HttpClient…DisableServerCertificateValidation: Fix Default HttpClient to honor DisableServerCertificateValidationFeb 1, 2024
@kirankumarkollikirankumarkolli changed the titleDisableServerCertificateValidation: Fix Default HttpClient to honor DisableServerCertificateValidationDisableServerCertificateValidation: Fixes Default HttpClient to honor DisableServerCertificateValidationFeb 1, 2024
…on and ServerCertificateCustomValidationCallback combination- Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)
@kirankumarkollikirankumarkolliforce-pushed theusers/kirankk/ssl_disable_server_cert_fix branch from0735a1b tof78efffCompareFebruary 2, 2024 04:23
@kirankumarkollikirankumarkolli added the auto-mergeEnables automation to merge PRs labelFeb 2, 2024
philipthomas-MSFT
philipthomas-MSFT previously approved these changesFeb 2, 2024
kundadebdatta
kundadebdatta previously approved these changesFeb 2, 2024
Copy link
Member

@kundadebdattakundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

FabianMeiswinkel
FabianMeiswinkel previously approved these changesFeb 2, 2024
Copy link
Member

@FabianMeiswinkelFabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

kirankumarkolli reacted with thumbs up emoji
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
ealsur
ealsur previously approved these changesFeb 2, 2024
FabianMeiswinkel
FabianMeiswinkel previously approved these changesFeb 2, 2024
Copy link
Member

@FabianMeiswinkelFabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@kundadebdattakundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Ideal if we could track this under a GitHub issue.

@microsoft-github-policy-servicemicrosoft-github-policy-servicebot deleted the users/kirankk/ssl_disable_server_cert_fix branchFebruary 2, 2024 23:02
kundadebdatta pushed a commit that referenced this pull requestFeb 7, 2024
… DisableServerCertificateValidation (#4294)* DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way* E2E Emulator test coverage* - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination- Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)* Addressing comments* Fixing a warning* Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.csCo-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>* Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.csCo-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>* Addressing commens* Undoing a change* Fixing UT* Renaming a test case name---------Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
kundadebdatta pushed a commit that referenced this pull requestFeb 7, 2024
… DisableServerCertificateValidation (#4294)* DisableServerCertificateValidation: Fix ensuring that both HttpClient and DocumentClient use a consistency way* E2E Emulator test coverage* - Supporting the combination of both DisableServerCertificateValidation and ServerCertificateCustomValidationCallback combination- Supporting test hook for DisableServerCertificateValidationInvocationCallback (specifically for only Disable checking)* Addressing comments* Fixing a warning* Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.csCo-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>* Update Microsoft.Azure.Cosmos/src/CosmosClientOptions.csCo-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>* Addressing commens* Undoing a change* Fixing UT* Renaming a test case name---------Co-authored-by: Fabian Meiswinkel <fabian@meiswinkel.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@ealsurealsurealsur approved these changes

@kundadebdattakundadebdattakundadebdatta approved these changes

@FabianMeiswinkelFabianMeiswinkelFabianMeiswinkel left review comments

@khdangkhdangAwaiting requested review from khdangkhdang is a code owner

@sboshrasboshraAwaiting requested review from sboshrasboshra is a code owner

@adityasaadityasaAwaiting requested review from adityasaadityasa is a code owner

@neildshneildshAwaiting requested review from neildshneildsh is a code owner

@kirillgkirillgAwaiting requested review from kirillgkirillg is a code owner

+1 more reviewer

@philipthomas-MSFTphilipthomas-MSFTphilipthomas-MSFT left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-mergeEnables automation to merge PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kirankumarkolli@ealsur@FabianMeiswinkel@philipthomas-MSFT@kundadebdatta
[8]ページ先頭
©2009-2025 Movatter.jp