- Notifications
You must be signed in to change notification settings - Fork4
Resolve key vault secret in parallel#192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
…ScriptProvider into zhiyuanliang/secret-performance
CsCherrYY approved these changesMay 14, 2025
986e3f0 intomain 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Why this PR?
#191
This change can bring about 40% speed-up when loading 10+ secrets.
Visible change
Added
KeyVaultOptions.parallelSecretResolutionEnabledoption to allow resolving key vault secret in parallel.Usage:
About Key Vault throttling
Key Vault allows 4000 transactions in 10 seconds, per vault per region.ref
Key Vault SDK cannot be used in browser because of CORS. I have verified this. So, for the potential browser scenario of JS provider, people should not use Key Vault reference there. This significantly reduces the chance of Key Vault throttling as Key Vault reference is only valid to use in server scenario.
For potential throttling response from Key Vault, thebest practice is to use the built-in retry policy configured through SecretClientOptions.
The provider supports either registering
SecretClientinstances or configuringSecretClientOptions.refAbout cache for Key Vault secret
Secret cache is added in#175