Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support load snapshot#140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zhiyuanliang-ms merged 20 commits intomainfromzhiyuanliang/select-snapshot
May 22, 2025
Merged

Conversation

@zhiyuanliang-ms
Copy link
Member

@zhiyuanliang-mszhiyuanliang-ms commentedDec 12, 2024•
edited
Loading

New API:

constconfig=awaitload(connectionString,{selectors:[{snapshotName:"MySnapshot"},// load keyvalue from snapshot{keyFilter:"test*",labelFilter:"test"}],featureFlagOptions:{enabled:true,selectors:[{snapshotName:"MySnapshot"},// load feature flags from snapshot{keyFilter:"*",labelFilter:"test"}]}});

Allow to use snapshot selector to load key value or feature flags

Note, for expilicity, if a snapshot contains feature flag, the feature flags will only be loaded when the snapshot is used forfeatureFlagOptions.selectors

This implementation is the same as kubernetes providerref andref

@zhiyuanliang-mszhiyuanliang-ms changed the base branch frompreview tozhiyuanliang/register-all-refreshDecember 12, 2024 07:56
Base automatically changed fromzhiyuanliang/register-all-refresh topreviewDecember 19, 2024 05:51
@zhiyuanliang-mszhiyuanliang-ms marked this pull request as ready for reviewDecember 19, 2024 08:37
Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/AzureAppConfigurationImpl.ts:946

  • Ensure that the logic for handling snapshot selectors, including the error conditions, is covered by tests.
if (selector.snapshotName) {

Base automatically changed frompreview torelease/v2January 7, 2025 09:43
@zhiyuanliang-mszhiyuanliang-ms changed the base branch fromrelease/v2 topreviewFebruary 12, 2025 05:11
@zhiyuanliang-mszhiyuanliang-ms changed the base branch frompreview tomainFebruary 20, 2025 07:31
@juniwang
Copy link
Member

the impl looks good to me. Should we add or update our test cases to cover snapshot?

@zhiyuanliang-ms
Copy link
MemberAuthor

@juniwang Do you mean add more testcases?

@juniwang
Copy link
Member

yes

@zhiyuanliang-mszhiyuanliang-ms merged commitddd19e0 intomainMay 22, 2025
6 checks passed
@zhiyuanliang-mszhiyuanliang-ms deleted the zhiyuanliang/select-snapshot branchMay 22, 2025 04:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@linglingye001linglingye001linglingye001 left review comments

Copilot code reviewCopilotCopilot left review comments

@juniwangjuniwangjuniwang approved these changes

@RichardChen820RichardChen820RichardChen820 approved these changes

@avaniguptaavaniguptaAwaiting requested review from avanigupta

@amerjusupovicamerjusupovicAwaiting requested review from amerjusupovic

@EskibearEskibearAwaiting requested review from Eskibear

@rossgramborossgramboAwaiting requested review from rossgrambo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhiyuanliang-ms@juniwang@RichardChen820@linglingye001
[8]ページ先頭
©2009-2025 Movatter.jp