- Notifications
You must be signed in to change notification settings - Fork403
PHP 8.2 compatibility error fixes#449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| private function maskSensitiveProperties ($obj) | ||
| if(strcmp($prop->getName(), $sensitiveField->tagName) == 0) { | ||
| $prop->setValue($obj, preg_replace($inputPattern, $inputReplacement, $prop->getValue($obj))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just tested this version, and this line needs the same fix you did on line 81.
| $prop->setValue($obj,preg_replace($inputPattern,$inputReplacement,$prop->getValue($obj))); | |
| $prop->setValue($obj,preg_replace($inputPattern,$inputReplacement,$prop->getValue($obj) ??'')); |
resumeblaze commentedJan 12, 2024
I didn't run into this error while testing PHP8.2 support in our application. I will need to update our forked version. Thank you for sharing your changes. I did see a deprecation notice that you can no longer dynamically declare a property and need to include |
OGProgrammer commentedJan 30, 2024
+1 on this, curious if this would fix upto 8.3 |
No description provided.