- Notifications
You must be signed in to change notification settings - Fork1.6k
Check in a fix for hostname validation failure.#714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
slandelle commentedSep 23, 2014
Could you change copyright to AsyncHttpClient Project and squash the commits, please? |
ContributorAuthor
wsargent commentedSep 23, 2014
@slandelle done. |
Contributor
slandelle commentedSep 23, 2014
Thanks! |
slandelle pushed a commit that referenced this pull requestSep 23, 2014
Check in a fix for hostname validation failure.
Contributor
slandelle commentedSep 23, 2014
Checking tests, and then releasing 1.8.14. |
Contributor
slandelle commentedSep 23, 2014
@wsargent Release done. |
Contributor
jroper commentedSep 30, 2014
Thanks@slandelle! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for#555