- Notifications
You must be signed in to change notification settings - Fork34
Fix false positive result where test passed even though gcc failed with error#342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Can you point me to an example of where this is happening and/or how I can reproduce it locally? Also, I'm not clear on how the change to |
7cb55a6 tof1395aaCompare| end.flatten | ||
| (additional_libraries +recursive).uniq | ||
| recursive.uniq | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you have a test case or some performance metric that relates to this change? Just trying to figure out whether this is an improved implementation or a bugfix
Even if gcc failed with errors for some of the files compiled for unit test, the test would still be reported as successful. This is fixed by properly increasing
@failure_count.Also an additional fix for the result calculation for
all_arduino_library_dependencies!. It is a long time since I made that commit so I do not exactly remember the details but reading it now accumulating with[n]inside themapsection looks more correct.Updates to CHANGELOG.md will trigger conflicts for this branch (
failure_handling.m, rebased on top ofmaster) when#338 is completed (or if this is done first, then#338 will get conflicts).There is an alternative branch
failure_handlingapplied in series with other branches that does not have those conflicts when#338 is completed. Let me know if you rather want that one merged (later).