NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit5cc25a0

authored

sponsors: implement better handling of benefit feature configuration naming (python#2523)

When cloning benefits year-to-year, search/replace the year if it is part of the name. Otherwise continue to suffix... this stops the internal_id_2022_2023_2024_2025 nonsense.

1 parent2a45f8c commit5cc25a0Copy full SHA for 5cc25a0

File tree

1 file changed

-1

lines changed

sponsors/models
- benefits.py

1 file changed

-1

lines changed

`‎sponsors/models/benefits.py`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,10 @@ def create_benefit_feature(self, sponsor_benefit, **kwargs):`
`146`	`146`
`147`	`147`	`defget_clone_kwargs(self,new_benefit):`
`148`	`148`	`kwargs=super().get_clone_kwargs(new_benefit)`
`149`		`-kwargs["internal_name"]=f"{self.internal_name}_{new_benefit.year}"`
	`149`	`+ifstr(self.benefit.year)inself.internal_name:`
	`150`	`+kwargs["internal_name"]=self.internal_name.replace(str(self.benefit.year),str(new_benefit.year))`
	`151`	`+else:`
	`152`	`+kwargs["internal_name"]=f"{self.internal_name}_{new_benefit.year}"`
`150`	`153`	`due_date=kwargs.get("due_date")`
`151`	`154`	`ifdue_date:`
`152`	`155`	`kwargs["due_date"]=due_date.replace(year=new_benefit.year)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5cc25a0

File tree

1 file changed

1 file changed

`‎sponsors/models/benefits.py`

0 commit comments