- Notifications
You must be signed in to change notification settings - Fork3
Lombok pitfalls#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
6e36b18 Init commit for Lombok pitfalls
honest-nicemaneeae687 1. Add @EqualsAndHashCode
honest-nicemana36e644 2. Comment @EqualsAndHashCode
honest-niceman2191060 3. Add proper Implementation for @EqualsAndHashCode
honest-nicemanb3f2e7e 4. @ToString leads to extra hits to database
honest-niceman03229d6 5. @ToString leads to StackOverflowError
honest-niceman53811c2 6. Fix @ToString with @ToString.Exclude
honest-niceman2804ba3 7. Add @Data annotation
honest-niceman33d1d37 8. Replace @Data with safe annotations
honest-niceman9b88556 9. Add @Builder annotation
honest-nicemane613cb5 10. Replace @Builder with safe annotations
honest-nicemanf34952c Make README.md better
honest-nicemanFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
14 changes: 14 additions & 0 deletionslombok-pitfalls/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Не используй Lombok с JPA, пока не посмотришь это видео | ||
| [](http://www.youtube.com/watch?v=7kdQTh4oOQM) | ||
| Текущая директория содержит несколько проектов, которые были использованы в видео: | ||
| 1. [equals-and-hash-code](equals-and-hash-code) | ||
| 2. [to-string](to-string) | ||
| 3. [data](data) | ||
| 4. [builder-and-allargsconstructor](builder-and-allargsconstructor) | ||
| Все действия производились в ветке `lombok-pitfalls`. | ||
| Первый коммит с которого можно начать повторять демо `6e36b183998145e4fa3f02daa5b985b681aeaff4`. |
37 changes: 37 additions & 0 deletionslombok-pitfalls/builder-and-allargsconstructor/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| HELP.md | ||
| .gradle | ||
| build/ | ||
| !gradle/wrapper/gradle-wrapper.jar | ||
| !**/src/main/**/build/ | ||
| !**/src/test/**/build/ | ||
| ### STS ### | ||
| .apt_generated | ||
| .classpath | ||
| .factorypath | ||
| .project | ||
| .settings | ||
| .springBeans | ||
| .sts4-cache | ||
| bin/ | ||
| !**/src/main/**/bin/ | ||
| !**/src/test/**/bin/ | ||
| ### IntelliJ IDEA ### | ||
| .idea | ||
| *.iws | ||
| *.iml | ||
| *.ipr | ||
| out/ | ||
| !**/src/main/**/out/ | ||
| !**/src/test/**/out/ | ||
| ### NetBeans ### | ||
| /nbproject/private/ | ||
| /nbbuild/ | ||
| /dist/ | ||
| /nbdist/ | ||
| /.nb-gradle/ | ||
| ### VS Code ### | ||
| .vscode/ |
31 changes: 31 additions & 0 deletionslombok-pitfalls/builder-and-allargsconstructor/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| plugins { | ||
| id 'java' | ||
| id 'org.springframework.boot' version '3.3.2' | ||
| id 'io.spring.dependency-management' version '1.1.6' | ||
| } | ||
| group = 'io.amplicode' | ||
| version = '0.0.1-SNAPSHOT' | ||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(17) | ||
| } | ||
| } | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
| dependencies { | ||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | ||
| runtimeOnly 'com.h2database:h2' | ||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | ||
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' | ||
| compileOnly 'org.projectlombok:lombok' | ||
| annotationProcessor 'org.projectlombok:lombok' | ||
| } | ||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| } |
Binary file not shown.
7 changes: 7 additions & 0 deletionslombok-pitfalls/builder-and-allargsconstructor/gradle/wrapper/gradle-wrapper.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
249 changes: 249 additions & 0 deletionslombok-pitfalls/builder-and-allargsconstructor/gradlew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,249 @@ | ||
| #!/bin/sh | ||
| # | ||
| # Copyright © 2015-2021 the original authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| ############################################################################## | ||
| # | ||
| # Gradle start up script for POSIX generated by Gradle. | ||
| # | ||
| # Important for running: | ||
| # | ||
| # (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is | ||
| # noncompliant, but you have some other compliant shell such as ksh or | ||
| # bash, then to run this script, type that shell name before the whole | ||
| # command line, like: | ||
| # | ||
| # ksh Gradle | ||
| # | ||
| # Busybox and similar reduced shells will NOT work, because this script | ||
| # requires all of these POSIX shell features: | ||
| # * functions; | ||
| # * expansions «$var», «${var}», «${var:-default}», «${var+SET}», | ||
| # «${var#prefix}», «${var%suffix}», and «$( cmd )»; | ||
| # * compound commands having a testable exit status, especially «case»; | ||
| # * various built-in commands including «command», «set», and «ulimit». | ||
| # | ||
| # Important for patching: | ||
| # | ||
| # (2) This script targets any POSIX shell, so it avoids extensions provided | ||
| # by Bash, Ksh, etc; in particular arrays are avoided. | ||
| # | ||
| # The "traditional" practice of packing multiple parameters into a | ||
| # space-separated string is a well documented source of bugs and security | ||
| # problems, so this is (mostly) avoided, by progressively accumulating | ||
| # options in "$@", and eventually passing that to Java. | ||
| # | ||
| # Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, | ||
| # and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; | ||
| # see the in-line comments for details. | ||
| # | ||
| # There are tweaks for specific operating systems such as AIX, CygWin, | ||
| # Darwin, MinGW, and NonStop. | ||
| # | ||
| # (3) This script is generated from the Groovy template | ||
| # https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt | ||
| # within the Gradle project. | ||
| # | ||
| # You can find Gradle at https://github.com/gradle/gradle/. | ||
| # | ||
| ############################################################################## | ||
| # Attempt to set APP_HOME | ||
| # Resolve links: $0 may be a link | ||
| app_path=$0 | ||
| # Need this for daisy-chained symlinks. | ||
| while | ||
| APP_HOME=${app_path%"${app_path##*/}"}# leaves a trailing /; empty if no leading path | ||
| [-h"$app_path" ] | ||
| do | ||
| ls=$( ls -ld"$app_path") | ||
| link=${ls#*' ->'} | ||
| case$linkin#( | ||
| /*) app_path=$link ;;#( | ||
| *) app_path=$APP_HOME$link ;; | ||
| esac | ||
| done | ||
| # This is normally unused | ||
| # shellcheck disable=SC2034 | ||
| APP_BASE_NAME=${0##*/} | ||
| # Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036) | ||
| APP_HOME=$(cd"${APP_HOME:-./}"> /dev/null&&pwd -P)||exit | ||
| # Use the maximum available, or set MAX_FD != -1 to use that value. | ||
| MAX_FD=maximum | ||
| warn () { | ||
| echo"$*" | ||
| }>&2 | ||
| die () { | ||
| echo | ||
| echo"$*" | ||
| echo | ||
| exit 1 | ||
| }>&2 | ||
| # OS specific support (must be 'true' or 'false'). | ||
| cygwin=false | ||
| msys=false | ||
| darwin=false | ||
| nonstop=false | ||
| case"$( uname)"in#( | ||
| CYGWIN* ) cygwin=true ;;#( | ||
| Darwin* ) darwin=true ;;#( | ||
| MSYS* | MINGW* ) msys=true ;;#( | ||
| NONSTOP* ) nonstop=true ;; | ||
| esac | ||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| # Determine the Java command to use to start the JVM. | ||
| if [-n"$JAVA_HOME" ];then | ||
| if [-x"$JAVA_HOME/jre/sh/java" ];then | ||
| # IBM's JDK on AIX uses strange locations for the executables | ||
| JAVACMD=$JAVA_HOME/jre/sh/java | ||
| else | ||
| JAVACMD=$JAVA_HOME/bin/java | ||
| fi | ||
| if [!-x"$JAVACMD" ];then | ||
| die"ERROR: JAVA_HOME is set to an invalid directory:$JAVA_HOME | ||
| Please set the JAVA_HOME variable in your environment to match the | ||
| location of your Java installation." | ||
| fi | ||
| else | ||
| JAVACMD=java | ||
| if!command -v java>/dev/null2>&1 | ||
| then | ||
| die"ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. | ||
| Please set the JAVA_HOME variable in your environment to match the | ||
| location of your Java installation." | ||
| fi | ||
| fi | ||
| # Increase the maximum file descriptors if we can. | ||
| if!"$cygwin"&&!"$darwin"&&!"$nonstop";then | ||
| case$MAX_FDin#( | ||
| max*) | ||
| # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. | ||
| # shellcheck disable=SC2039,SC3045 | ||
| MAX_FD=$(ulimit -H -n)|| | ||
| warn"Could not query maximum file descriptor limit" | ||
| esac | ||
| case$MAX_FDin#( | ||
| '' | soft):;;#( | ||
| *) | ||
| # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. | ||
| # shellcheck disable=SC2039,SC3045 | ||
| ulimit -n"$MAX_FD"|| | ||
| warn"Could not set maximum file descriptor limit to$MAX_FD" | ||
| esac | ||
| fi | ||
| # Collect all arguments for the java command, stacking in reverse order: | ||
| # * args from the command line | ||
| # * the main class name | ||
| # * -classpath | ||
| # * -D...appname settings | ||
| # * --module-path (only if needed) | ||
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. | ||
| # For Cygwin or MSYS, switch paths to Windows format before running java | ||
| if"$cygwin"||"$msys";then | ||
| APP_HOME=$( cygpath --path --mixed"$APP_HOME") | ||
| CLASSPATH=$( cygpath --path --mixed"$CLASSPATH") | ||
| JAVACMD=$( cygpath --unix"$JAVACMD") | ||
| # Now convert the arguments - kludge to limit ourselves to /bin/sh | ||
| for argdo | ||
| if | ||
| case$argin#( | ||
| -*)false ;;# don't mess with options #( | ||
| /?*) t=${arg#/} t=/${t%%/*}# looks like a POSIX filepath | ||
| [-e"$t" ] ;;#( | ||
| *)false ;; | ||
| esac | ||
| then | ||
| arg=$( cygpath --path --ignore --mixed"$arg") | ||
| fi | ||
| # Roll the args list around exactly as many times as the number of | ||
| # args, so each arg winds up back in the position where it started, but | ||
| # possibly modified. | ||
| # | ||
| # NB: a `for` loop captures its iteration list before it begins, so | ||
| # changing the positional parameters here affects neither the number of | ||
| # iterations, nor the values presented in `arg`. | ||
| shift# remove old arg | ||
| set --"$@""$arg"# push replacement arg | ||
| done | ||
| fi | ||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | ||
| # Collect all arguments for the java command: | ||
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | ||
| # and any embedded shellness will be escaped. | ||
| # * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be | ||
| # treated as '${Hostname}' itself on the command line. | ||
| set -- \ | ||
| "-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
| -classpath"$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| "$@" | ||
| # Stop when "xargs" is not available. | ||
| if!command -v xargs>/dev/null2>&1 | ||
| then | ||
| die"xargs is not available" | ||
| fi | ||
| # Use "xargs" to parse quoted args. | ||
| # | ||
| # With -n1 it outputs one arg per line, with the quotes and backslashes removed. | ||
| # | ||
| # In Bash we could simply go: | ||
| # | ||
| # readarray ARGS < <( xargs -n1 <<<"$var" ) && | ||
| # set -- "${ARGS[@]}" "$@" | ||
| # | ||
| # but POSIX shell has neither arrays nor command substitution, so instead we | ||
| # post-process each arg (as a line of input to sed) to backslash-escape any | ||
| # character that might be a shell metacharacter, then use eval to reverse | ||
| # that process (while maintaining the separation between arguments), and wrap | ||
| # the whole thing up as a single "set" statement. | ||
| # | ||
| # This will of course break if any of these variables contains a newline or | ||
| # an unmatched quote. | ||
| # | ||
| eval"set --$( | ||
| printf'%s\n'"$DEFAULT_JVM_OPTS$JAVA_OPTS$GRADLE_OPTS"| | ||
| xargs -n1| | ||
| sed' s~[^-[:alnum:]+,./:=@_]~\\&~g;'| | ||
| tr'\n''' | ||
| )"'"$@"' | ||
| exec"$JAVACMD""$@" |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.