Commit4026932

committed

Fix insecure PINs for HomeKit server

1 parent45cbbaf commit4026932Copy full SHA for 4026932

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,11 +71,17 @@ type JSONCharacter struct {`
`71`	`71`	Eventany`json:"ev,omitempty"`
`72`	`72`	`}`
`73`	`73`
	`74`	`+// 4.2.1.2 Invalid Setup Codes`
	`75`	`+constinsecurePINs="00000000 11111111 22222222 33333333 44444444 55555555 66666666 77777777 88888888 99999999 12345678 87654321"`
	`76`	`+`
`74`	`77`	`funcSanitizePin(pinstring) (string,error) {`
`75`	`78`	`s:=strings.ReplaceAll(pin,"-","")`
`76`	`79`	`iflen(s)!=8 {`
`77`	`80`	`return"",errors.New("hap: wrong PIN format: "+pin)`
`78`	`81`	`}`
	`82`	`+ifstrings.Contains(insecurePINs,s) {`
	`83`	`+return"",errors.New("hap: insecure PIN: "+pin)`
	`84`	`+}`
`79`	`85`	`// 123-45-678`
`80`	`86`	`returns[:3]+"-"+s[3:5]+"-"+s[5:],nil`
`81`	`87`	`}`

Comments

(0)