Codecov Report

Merging#847 intodevelop willincrease coverage by0.01%.
The diff coverage is100%.

@@             Coverage Diff             @@##           develop     #847      +/-   ##===========================================+ Coverage    67.73%   67.75%   +0.01%===========================================  Files            1        1                Lines         9881     9886       +5       Branches      2949     2949              ===========================================+ Hits          6693     6698       +5  Misses        3188     3188

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec5814b8...5175edb. Read thecomment docs.

@mathiasrw, I'll probably need help on the tests. This scenario here only affects localstorage, but all the tests seem to be running in a node environment, how do I test local storage specific code?

Of cause...

I suggest you do a

npm install --save-dev node-localstorage

and make a test that starts with

if (typeof localStorage === "undefined" || localStorage === null) {  var LocalStorage = require('node-localstorage').LocalStorage;  localStorage = new LocalStorage('./testxxx.localstorage');}```Then everything should work :)

@mathiasrw, I have modified an existing test to only pass with the modifications added in this PR. Looks like there was support for writing LocalStorage tests in alasql already after all! Very cool. Unfortunately, there are other places where autoincrement for locastorage ought to work, but somehow still isn't (e.g. test389 when AUTOCOMMIT is off), I'll investigate them.

Really nice work.

Let me know when to merge the PR.

Any news on this?

Sorry, I got a bit busier than expected and this was a little harder to track down than I thought... Perhaps let's merge this PR first, but not close the issue. I'll work on this sometime next weekend when I have more time.