- Notifications
You must be signed in to change notification settings - Fork689
Verify PATH keyword already works as identifier via NonReserved list#2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intodevelopChoose a base branch fromcopilot/limit-keyword-path-impact
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
CopilotAI changed the title[WIP] Update grammar to limit the impact of keyword PATHVerify PATH keyword already works as identifier via NonReserved listDec 16, 2025
mathiasrw requested changesDec 17, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please rename to test2222.js
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Renamed to test2222.js in commitf3583af
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The issue requested limiting the impact of the PATH keyword so it can be used as table/column names while remaining a keyword for graph search operations.
Investigation Results
PATH is already in the
NonReservedlist (line 3171 inalasqlparser.jison), which allows it to function as an identifier through the Literal rule's error recovery mechanism. This is the standard LR parser pattern for non-reserved keywords.Changes
test/test2222.js) covering:Example Usage
Conclusion
No grammar changes needed. The current implementation is optimal - PATH functions as a keyword in SearchSelector context while being usable as an identifier elsewhere. All 2109 tests pass.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.