- Notifications
You must be signed in to change notification settings - Fork689
Implement JavaScript property access in SQL queries#2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Changes from3 commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -35,13 +35,14 @@ describe('Test 341 Intellectual DOT operator', function () { | ||
| done(); | ||
| }); | ||
| it('4. JavaScript way', function (done) { | ||
| var res = alasql('SET @a = "who".length'); | ||
| assert.deepEqual(res, 1); | ||
| assert.deepEqual(alasql.vars.a, 3); | ||
| done(); | ||
| }); | ||
| it('5. JavaScript way', function (done) { | ||
| var res = alasql('SELECT COLUMN name.length FROM persons'); | ||
| assert.deepEqual(res, [6, 6, 7]); | ||
| done(); | ||
Comment on lines -44 to 47 Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Can we adda a test if I can name a table.col.length ? ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Added test for The three-level dot notation already works correctly with the current implementation. Added test "6. JavaScript way with table.column.length" that verifies:
All 2086 tests passing. Commit:ddb0088 Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. | ||
Uh oh!
There was an error while loading.Please reload this page.