- Notifications
You must be signed in to change notification settings - Fork689
Fix primary key enforcement for IndexedDB tables#2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge5 commits intodevelopChoose a base branch fromcopilot/fix-primary-key-error
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix issue with primary key allowing duplicate valuesFix primary key enforcement for IndexedDB tablesNov 30, 2025
mathiasrw requested changesNov 30, 2025
Member
mathiasrw left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
mathiasrw approved these changesNov 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Thank you for the time you are putting into AlaSQL!
Description
Fixes#1292 - Primary keys defined in CREATE TABLE were not enforced when using IndexedDB storage, allowing duplicate values.
Root cause:
IDB.createTablealways created object stores with{autoIncrement: true}, ignoring user-defined primary key columns.Changes:
IDB.createTable: Use IndexedDB'skeyPathoption for primary key columns{keyPath: columnName}{keyPath: [col1, col2, ...]}{autoIncrement: true}(unchanged behavior)IDB.intoTable: HandleConstraintErrorfrom IndexedDB when duplicate keys are inserted, returning consistent error messageExample:
Test: Added
test/test1292.jscovering column-level and table-level PK syntax.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
upload.wikimedia.org/usr/local/bin/node /usr/local/bin/node node_modules/mocha/bin/mocha.js ./test --reporter dot --bail(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.