- Notifications
You must be signed in to change notification settings - Fork689
Add _all_ date function aliases to parser (extended)#1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
paulrutter wants to merge11 commits intoAlaSQL:developChoose a base branch fromblueconic:feature/1979-add-date-function-aliases-to-parser-extended
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
677dabd 1979
paulrutter444e8b1 1979-add-date-function-aliases-to-parser
paulrutter620426d 1979-add-date-function-aliases-to-parser
paulrutter51bf815 1979-add-date-function-aliases-to-parser
paulrutter30813b9 1979-add-date-function-aliases-to-parser
paulrutterce49690 - Fix DAYOFYEAR; it's a separate function
paulrutter9431515 - Merge in develop, fix conflicts
paulrutter9960b5e - Regenerate after merge
paulrutterdced7b1 - Remove DAYOFWEEK from intervals, add WEEKDAY to valid intervals
paulrutter741599f Merge branch 'develop_2' into feature/1979-add-date-function-aliases-…
paulrutter96b48bf Merge branch 'develop' into feature/1979-add-date-function-aliases-to…
paulrutterFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Fix DAYOFYEAR; it's a separate function
- Add date function aliases to parser
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitce49690c35088dfd471f1a4c7d4395e477bee03c
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
4 changes: 2 additions & 2 deletionssrc/alasqlparser.jison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -113,7 +113,7 @@ COLUMNS return 'COLUMN' | ||
| DATABASE(S)?return 'DATABASE' | ||
| 'DAY'return 'DAY' | ||
| 'DAYOFMONTH'return 'DAY' | ||
mathiasrw marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| 'DAYOFYEAR'return 'DAYOFYEAR' | ||
| 'DATEADD' return 'DATEADD' | ||
| 'DATEDIFF' return 'DATEDIFF' | ||
| 'DAYOFWEEK'return 'DAYOFWEEK' | ||
| @@ -1451,7 +1451,7 @@ FuncValue | ||
| | DATE_SUB LPAR Expression COMMA INTERVAL Expression IntervalLiteral RPAR | ||
| /* e.g. DATE_SUB(NOW(), INTERVAL 10 day) */ | ||
| { $$ = new yy.FuncValue({ funcid: 'DATE_SUB', args:[$3, new yy.FuncValue({ funcid: 'INTERVAL', args:[$6,new yy.StringValue({value:($7).toLowerCase()})]}) ]}) } | ||
| | (YEAR|MONTH|DAY|DAYOFMONTH|DAYOFWEEK|WEEKDAY|HOUR|MINUTE|SECOND) LPAR Expression RPAR | ||
| { $$ = new yy.FuncValue({ funcid: $1, args: [$3] }) } | ||
| | TIMESTAMPDIFF LPAR Expression COMMA Expression COMMA Expression RPAR | ||
| { $$ = new yy.FuncValue({ funcid: 'TIMESTAMPDIFF', args: [new yy.StringValue({value:$3}),$5,$7]}) } | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.