Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit39944c4

Browse files
committed
fix race condition in server reporting errors to client
1 parent25c91b7 commit39944c4

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

‎src/lib.rs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -273,18 +273,6 @@ impl<H> Future for Pipe<H> where H: PacketHandler + 'static {
273273
loop{
274274
let client_read =self.client_reader.read();
275275

276-
// if the client connection has closed, close the server connection too
277-
match&client_read{
278-
&Err(ref e) =>{
279-
debug!("Client closed connection: {}", e);
280-
matchself.server_writer.stream.shutdown(Shutdown::Write){
281-
Ok(_) =>{},
282-
Err(_) =>{}
283-
}
284-
},
285-
_ =>{}
286-
}
287-
288276
// process buffered requests
289277
whileletSome(request) =self.client_reader.next(){
290278
matchself.handler.handle_request(&request){
@@ -306,18 +294,6 @@ impl<H> Future for Pipe<H> where H: PacketHandler + 'static {
306294
// try reading from server
307295
let server_read =self.server_reader.read();
308296

309-
// if the server connection has closed, close the client connection too
310-
match&server_read{
311-
&Err(ref e) =>{
312-
debug!("Server closed connection: {}", e);
313-
matchself.client_writer.stream.shutdown(Shutdown::Write){
314-
Ok(_) =>{},
315-
Err(_) =>{}
316-
}
317-
},
318-
_ =>{}
319-
}
320-
321297
// process buffered responses
322298
whileletSome(response) =self.server_reader.next(){
323299
matchself.handler.handle_response(&response){
@@ -342,9 +318,33 @@ impl<H> Future for Pipe<H> where H: PacketHandler + 'static {
342318
// try writing to client
343319
let client_write =self.client_writer.write();
344320

321+
// if the server connection has closed, close the client connection too
322+
match&server_read{
323+
&Err(ref e) =>{
324+
debug!("Server closed connection: {}", e);
325+
matchself.client_writer.stream.shutdown(Shutdown::Write){
326+
Ok(_) =>{},
327+
Err(_) =>{}
328+
}
329+
},
330+
_ =>{}
331+
}
332+
345333
// try writing to server
346334
let server_write =self.server_writer.write();
347335

336+
// if the client connection has closed, close the server connection too
337+
match&client_read{
338+
&Err(ref e) =>{
339+
debug!("Client closed connection: {}", e);
340+
matchself.server_writer.stream.shutdown(Shutdown::Write){
341+
Ok(_) =>{},
342+
Err(_) =>{}
343+
}
344+
},
345+
_ =>{}
346+
}
347+
348348
try_ready!(client_read);
349349
try_ready!(client_write);
350350
try_ready!(server_read);

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp