- Notifications
You must be signed in to change notification settings - Fork4
2.7.18.10 dev#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:2.7.18.x_old
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Update News and patch level.
This should be handled dynmically by the new compiler.
rickprice left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
ucodery left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't see anything alarming here
| ifmajorVersion>=13: | ||
| majorVersion+=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why are we doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I saw the comment in all the other places this was done. Still not sure I understand it, but a reason was given.
| # Use the .lib files for the correct architecture | ||
| ifself.plat_name=='win32': | ||
| suffix='' | ||
| suffix='win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This leavessuffix undefined in certain circumstances.
Review additional Compiler Updates