Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix missing Emphasis infotext#16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Haoming02 wants to merge1 commit intoAUTOMATIC1111:dev
base:dev
Choose a base branch
Loading
fromHaoming02:fix-emphasis

Conversation

@Haoming02
Copy link
Contributor

Description

  • Simple Description: Currently, in certain situations(seeRepro), theEmphasis parameter would be missing from the infotext
  • Summary of Changes: Moved the code that adds this parameter intocreate_infotext function

Repro

  1. EnablePersistent cond cache in settings
  2. Generate an image that contains emphasis
    • notice theEmphasis: ... in infotext
  3. Generate again with the exact same parameters(Seed can vary)
    • notice theEmphasis: ... is now missing
  4. Reload UI
  5. Click theRead generation parameters button (↙️)
  6. See theOverride settings now shows up as a result
  • TL;DR: Currently, theEmphasis parameter is added duringCLIP processing. So if you enable thePersistent cond cache, theCLIP no longer gets called in subsequent generations, thus missing the parameter.

Checklist

@w-e-w
Copy link
Collaborator

I also notice the issue with the entirer sd_hijack_clip.py
I have a WIP that I haven't had time to finish

Haoming02 reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AUTOMATIC1111AUTOMATIC1111Awaiting requested review from AUTOMATIC1111AUTOMATIC1111 is a code owner

@w-e-ww-e-wAwaiting requested review from w-e-ww-e-w is a code owner

@catboxanoncatboxanonAwaiting requested review from catboxanoncatboxanon is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Haoming02@w-e-w
[8]ページ先頭
©2009-2025 Movatter.jp