- Notifications
You must be signed in to change notification settings - Fork29.5k
Added support for Docker Build/Compose and K8S#16737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Conversation
5a0fa91 tof7d5d35Comparepanpan0000 commentedDec 23, 2024
@ShadowCrafter011 already updated his PR#16688 |
8618359 tofae2f2fCompare.dockerignore Outdated
| .che__/ | ||
| *.log | ||
| *.git | ||
| *.gitignoreivenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what is going on with these ignore entries? "che", "gitignoreivenv", ... what?
Also shouldn't egembeddings,extensions, etc. be ignored here? (ie anything that has a separate bind to forward it in)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
.che__ is Eclipse env.
gitignoreivenv is a typo ... should be gitignore and .venv...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
README.md Outdated
| cd stable-diffusion-webui | ||
| export TAG=v1.10.0 | ||
| docker build -t stable-diffusion-webui:${TAG} -f docker/Dockerfile . | ||
| docker run --gpus all -d -p 7860:7860 stable-diffusion-webui:${TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(A) Minor, but formatting is a little weird here, double-spacing left in.
(B) Minor, but also the tag usage seems a bit unusual.
(C) the-v for models isn't really optional, it should be included not a "if you happen to already have models". This line should have all the same contents as the compose does by default.
panpan0000Dec 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thank you. fixed
hmm, about (c) , after careful thought, you are right .even without pre-download model files in volume or in container, the webui.sh will still download image when containers up
silveroxides commentedDec 23, 2024
There is already a docker image that have been maintained for over 1½ years. You can absolutely make a repo dedicated to build/compose of the webui and have it linked by the main repo so people can find it. But introducing Dockerfiles in to the main repo doesn't make much sense. |
panpan0000 commentedDec 24, 2024
we can discuss this topic in thread :#16688 |
Co-authored-by: Lukas <lkoe@bluewin.ch>Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
| COPY . . | ||
| RUN dos2unix ./webui.sh ./webui-user.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this needed? I don't see thewebui-user.sh being used.
| RUN apt-get update && \ | ||
| apt-get install ffmpeg libsm6 libxext6 dos2unix google-perftools -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is also suggested to addapt-get clean orrm -rf /var/cache/apt/archives /var/lib/apt/lists/* here to remove any cached files that will just take up space for no reason.
| *.git | ||
| *.gitignore | ||
| docker | ||
| models/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thinkoutputs/* is missing from here.
gimmelovn commentedJun 20, 2025
this docker image should be referenced in the wiki sectionhttps://hub.docker.com/r/universonic/stable-diffusion-webui |
Description
Merging the PR from#16688
Add dockerfile for docker build
Added support for containerization with Docker. To run webui you need to have Docker installed, clone the repository and execute docker compose up in the root directory of the repository. The first startup installs all the dependencies and subsequent startups are much quicker. The webui is exposed at localhost:7860
Add support for k8s yaml
will add CI for automatic docker image build and pushing to dockerhub later
Screenshots/videos:
Checklist: