Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[bug] do not break progressbar on non-job actions (add wrap_gradio_call_no_job)#16202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@light-and-ray
Copy link
Contributor

@light-and-raylight-and-ray commentedJul 12, 2024•
edited
Loading

Description

This PR fixes an annoying bug:

  1. Start batch processing
  2. Go to settings (even it different browser tab)
  3. Click "Apply Settings", or other little functions like "save zip"
  4. Progressbar is broken until the generation end

The better function name would bewrap_gradio_call and rename old towrap_gradio_job, but it will break an interface for extensions

Checklist:

Panchovix and elistys reacted with thumbs up emoji
@light-and-ray
Copy link
ContributorAuthor

light-and-ray commentedJul 12, 2024•
edited
Loading

But maybe the better naming wont break anything, becausewrap_gradio_call (with no gpu) with meaning it will use progress bar appears very-very rare. In vanilla only on extensions list loading from remote, I think extensions doesn't use it at all

Panchovix pushed a commit to Panchovix/stable-diffusion-webui-reForge that referenced this pull requestJul 13, 2024
@AUTOMATIC1111AUTOMATIC1111 merged commit7c8a4cc intoAUTOMATIC1111:devJul 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AUTOMATIC1111AUTOMATIC1111AUTOMATIC1111 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@light-and-ray@AUTOMATIC1111
[8]ページ先頭
©2009-2025 Movatter.jp