AUTOMATIC1111/stable-diffusion-webuiPublic

NotificationsYou must be signed in to change notification settings
Fork29.5k
Star159k

Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py#14354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

AUTOMATIC1111 merged 2 commits intoAUTOMATIC1111:devfromranareehanaslam:master

Dec 30, 2023

Merged

Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py#14354

AUTOMATIC1111 merged 2 commits intoAUTOMATIC1111:devfromranareehanaslam:master

Dec 30, 2023

Conversation

Copy link

Contributor

ranareehanaslam commentedDec 18, 2023•
edited
Loading

Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed

Description

There was a issue in the Script webui.py
when anyone want to run theapi only withno webui arguments it was only loading it to thelocal server only if no listen is passed and eitherserver-name is passed it was being ignored i have fixed It Further Proof of Concept and Screenshot's are attached

testing COMMANDLINE_ARGS
--disable-safe-unpickle --server-name [::] --xformers --opt-sdp-attention --enable-insecure-extension-access --api --opt-channelslast --nowebui --no-gradio-queue --port 7860 --ui-settings-file 'config.json' --ui-config-file 'ui-config.json' --no-download-sd-model

Screenshots/videos:

BEFORE FIX

AFTER FIX

Checklist:

I have readcontributing wiki page
I have performed a self-review of my own code
My code follows thestyle guidelines
My code passestests

Update webui.py

fe4d084

Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed

ranareehanaslam requested a review fromAUTOMATIC1111 as acode owner

December 18, 2023 12:53

Copy link

ContributorAuthor

ranareehanaslam commentedDec 18, 2023

@AUTOMATIC1111 Waiting for your Response sir!

akx reviewed

Dec 18, 2023

View reviewed changes

webui.py OutdatedShow resolvedHide resolved

Copy link

Collaborator

akx commentedDec 18, 2023

Please actually readthe contributing guidelines.

You're violating at least 2 of the bullet points.

ranareehanaslam changed the title~~Update webui.py~~Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py

Dec 19, 2023

Update webui.py

0d5941e

Co-authored-by: Aarni Koskela <akx@iki.fi>

Copy link

ContributorAuthor

ranareehanaslam commentedDec 19, 2023

Please actually readthe contributing guidelines.
You're violating at least 2 of the bullet points.

is it really mean it ..?
am just helping the community

Copy link

Collaborator

akx commentedDec 19, 2023

is it really mean it ..? am just helping the community

That may be, but you need to abide by the project's rules. The violations I can see are related to the branch you're targeting, and the branch you're making your PR from.

Copy link

Contributor

dhwz commentedDec 19, 2023•
edited
Loading

Please actually readthe contributing guidelines.
You're violating at least 2 of the bullet points.
is it really mean it ..? am just helping the community

I'm sorry but I think you still don't understand what he is talking about.
Any changes for PRs have to be done in the dev branch, you did change the code in master branch and started a PR from there, merging changes from master into dev is NOT allowed, please redo your changes in dev branch and then open a proper NEW PR.

akx requested changes

Dec 19, 2023

View reviewed changes

webui.py

		print(f"Startup time:{startup_timer.summary()}.")
		api.launch(
		server_name="0.0.0.0"ifcmd_opts.listenelse"127.0.0.1",
		server_name=cmd_opts.server_nameor ("0.0.0.0"ifcmd_opts.listenelse"127.0.0.1"),

Copy link

Collaborator

akxDec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As pointed out on Discord, this should use theinitialize_util.gradio_server_name() function that's available in thedev branch.

Thedev branch is what this PR should be targeting; a PR targetingmaster will not get merged.

missionfloyd changed the base branch frommaster todev

December 21, 2023 03:46

AUTOMATIC1111 approved these changes

Dec 30, 2023

View reviewed changes

AUTOMATIC1111 merged commit83c0758 intoAUTOMATIC1111:dev

Dec 30, 2023

AUTOMATIC1111 added a commit that referenced this pull request

Dec 30, 2023

update#14354

f0e2e8b

Copy link

Owner

AUTOMATIC1111 commentedDec 30, 2023

So the actual issue from previous PRs was that the API-only was just ignoring some cmdline args, which does seem like a real problem. I merged this, and applied the change akx suggested.