Commit9461f44

committed

fix "AttributeError: 'Request' object has no attribute 'user'"; add 1 test case for apijson-head

1 parentd2ab647 commit9461f44Copy full SHA for 9461f44

File tree

2 files changed

+18

-7

lines changed

tests
- test.py
uliweb_apijson/apijson
- views.py

2 files changed

+18

-7

lines changed

`‎tests/test.py`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -864,4 +864,15 @@ def test_apijson_head():`
`864`	`864`	`>>> d = json_loads(r.data)`
`865`	`865`	`>>> print(d)`
`866`	`866`	`{'code': 400, 'msg': "no login user for role 'ADMIN'"}`
	`867`	`+`
	`868`	`+ >>> #apijson head, without user and @role`
	`869`	`+ >>> data ='''{`
	`870`	`+ ... "privacy": {`
	`871`	`+ ... "id": 1`
	`872`	`+ ... }`
	`873`	`+ ... }'''`
	`874`	`+ >>> r = handler.post('/apijson/head', data=data, middlewares=[])`
	`875`	`+ >>> d = json_loads(r.data)`
	`876`	`+ >>> print(d)`
	`877`	`+ {'code': 400, 'msg': "role 'UNKNOWN' not have permission HEAD for 'privacy'"}`
`867`	`878`	`"""`

`‎uliweb_apijson/apijson/views.py`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -112,12 +112,12 @@ def _get_one(self,key):`
`112`	`112`	`roles=GET.get("roles")`
`113`	`113`	`permission_check_ok=False`
`114`	`114`	`ifnotparams_role:`
`115`		`-ifhasattr(request,"user"):`
	`115`	`+ifhasattr(request,"user")andrequest.user:`
`116`	`116`	`params_role="LOGIN"`
`117`	`117`	`else:`
`118`	`118`	`params_role="UNKNOWN"`
`119`	`119`	`elifparams_role!="UNKNOWN":`
`120`		`-ifnothasattr(request,"user"):`
	`120`	`+ifnot(hasattr(request,"user")andrequest.user):`
`121`	`121`	`returnjson({"code":400,"msg":"no login user for role '%s'"%(params_role)})`
`122`	`122`	`ifparams_rolenotinroles:`
`123`	`123`	`returnjson({"code":400,"msg":"'%s' not accessible by role '%s'"%(model_name,params_role)})`
`@@ -290,15 +290,15 @@ def _head(self,key):`
`290`	`290`	`roles=HEAD.get("roles")`
`291`	`291`	`permission_check_ok=False`
`292`	`292`	`ifnotparams_role:`
`293`		`-ifrequest.user:`
	`293`	`+ifhasattr(request,"user")andrequest.user:`
`294`	`294`	`params_role="LOGIN"`
`295`	`295`	`else:`
`296`	`296`	`params_role="UNKNOWN"`
`297`	`297`	`ifparams_rolenotinroles:`
`298`	`298`	`returnjson({"code":400,"msg":"role '%s' not have permission HEAD for '%s'"%(params_role,model_name)})`
`299`	`299`	`ifparams_role=="UNKNOWN":`
`300`	`300`	`permission_check_ok=True`
`301`		`-elifnothasattr(request,"user"):`
	`301`	`+elifnot(hasattr(request,"user")andrequest.user):`
`302`	`302`	`returnjson({"code":400,"msg":"no login user for role '%s'"%(params_role)})`
`303`	`303`	`eliffunctions.has_role(request.user,params_role):`
`304`	`304`	`permission_check_ok=True`
`@@ -387,7 +387,7 @@ def _post_one(self,key,tag):`
`387`	`387`	`ifroles:`
`388`	`388`	`forroleinroles:`
`389`	`389`	`ifrole=="OWNER":`
`390`		`-ifrequest.user:`
	`390`	`+ifhasattr(request,"user")andrequest.user:`
`391`	`391`	`permission_check_ok=True`
`392`	`392`	`ifuser_id_field:`
`393`	`393`	`params[user_id_field]=request.user.id`
`@@ -506,7 +506,7 @@ def _put_one(self,key,tag):`
`506`	`506`	`ifroles:`
`507`	`507`	`forroleinroles:`
`508`	`508`	`ifrole=="OWNER":`
`509`		`-ifrequest.user:`
	`509`	`+ifhasattr(request,"user")andrequest.user:`
`510`	`510`	`ifuser_id_field:`
`511`	`511`	`ifobj.to_dict().get(user_id_field)==request.user.id:`
`512`	`512`	`permission_check_ok=True`
`@@ -627,7 +627,7 @@ def _delete_one(self,key,tag):`
`627`	`627`	`ifroles:`
`628`	`628`	`forroleinroles:`
`629`	`629`	`ifrole=="OWNER":`
`630`		`-ifrequest.user:`
	`630`	`+ifhasattr(request,"user")andrequest.user:`
`631`	`631`	`ifuser_id_field:`
`632`	`632`	`ifobj.to_dict().get(user_id_field)==request.user.id:`
`633`	`633`	`permission_check_ok=True`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9461f44

File tree

2 files changed

2 files changed

`‎tests/test.py`

`‎uliweb_apijson/apijson/views.py`

0 commit comments