Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

replaced unicornafl with unicorn#2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
domenukk merged 3 commits intoAFLplusplus:devfromResery:patch-1
Feb 19, 2024
Merged

replaced unicornafl with unicorn#2003

domenukk merged 3 commits intoAFLplusplus:devfromResery:patch-1
Feb 19, 2024

Conversation

@Resery
Copy link
Contributor

The submodule of unicorn cannot be imported through unicornafl.*_const here. If we want to use the *_const module, we should referencefrom unicorn.*_const import * like this instead of importing the entire contents of the *_const module via unicornafl。

vanhauser-thcand others added3 commitsFebruary 3, 2024 10:55
* Output afl-clang-fast stuffs only if necessary (#1912)* afl-cc header* afl-cc common declarations - Add afl-cc-state.c - Strip includes, find_object, debug/be_quiet/have_*/callname setting from afl-cc.c - Use debugf_args in main - Modify execvp stuffs to fit new aflcc struct* afl-cc show usage* afl-cc mode selecting1. compiler_mode by callname in argv[0]2. compiler_mode by env "AFL_CC_COMPILER"3. compiler_mode/instrument_mode by command line options "--afl-..."4. instrument_mode/compiler_mode by various env vars including "AFL_LLVM_INSTRUMENT"5. final checking steps6. print "... - mode: %s-%s\n"7. determine real argv[0] according to compiler_mode* afl-cc macro defs* afl-cc linking behaviors* afl-cc fsanitize behaviors* afl-cc misc* afl-cc body update* afl-cc all-in-oneformated with custom-format.py* nits---------Co-authored-by: vanhauser-thc <vh@thc.org>* changelog* update grammar mutator* lto llvm 12+* docs(custom_mutators): fix missing ':' (#1953)* Fix broken LTO mode and response file support (#1948)* Strip `-Wl,-no-undefined` during compilation (#1952)Make the compiler wrapper stripping `-Wl,-no-undefined` in addition to `-Wl,--no-undefined`.Both versions of the flag are accepted by clang and, therefore, used by building systems in the wild (e.g., samba will not build without this fix).* Remove dead code in write_to_testcase (#1955)The custom_mutators_count check in if case is duplicate with if condition.The else case is custom_mutators_count == 0, neither custom_mutator_list iteration nor sent check needed.Signed-off-by: Xeonacid <h.dwwwwww@gmail.com>* update qemuafl* WIP: Add ability to generate drcov trace using QEMU backend (#1956)* Document new drcov QEMU plugin* Add link to lightkeeper for QEMU drcov file loading---------Co-authored-by: Jean-Romain Garnier <jean-romain.garnier@airbus.com>* code format* changelog* sleep on uid != 0 afl-system-config* fix segv about skip_next, warn on unsupported cases of linking options (#1958)* todos* ensure afl-cc only allows available compiler modes* update grammar mutator* disable aslr on apple* fix for arm64* help selective instrumentation* typos* macos* add compiler test script* apple fixes* bump nyx submodules (#1963)* fix docs* update changelog* update grammar mutator* improve compiler test script* gcc asan workaround (#1966)* fix github merge fuckup* fix* Fix afl-cc (#1968)- Check if too many cmdline params here, each time before insert a new param. - Check if it is "-fsanitize=..." before we do sth. - Remove improper param_st transfer.* Avoid adding llvmnative instrumentation when linking rust sanitizer runtime (#1969)* Dynamic instrumentation filtering for LLVM native (#1971)* Add two dynamic instrumentation filter methods to runtime* Always use pc-table with native pcguard* Add make_symbol_list.py and README* changelog* todos* new forkserver check* fix* nyx test for CI* improve nyx docs* Fixes to afl-cc and documentation (#1974)* Always compile with -ldl when building for CODE_COVERAGEWhen building with CODE_COVERAGE, the afl runtime contains code thatcalls `dladdr` which requires -ldl. Under most circumstances, clangalready adds this (e.g. when building with pc-table), but there are somecircumstances where it isn't added automatically.* Add visibility declaration to __afl_connectedWhen building with hidden visibility, the use of __AFL_LOOP inside suchcode can cause linker errors due to __afl_connected being declared"hidden".* Update docs to clarify that CODE_COVERAGE=1 is required for dynamic_covfilter* nits* nyx build script updates* test error output* debug ci* debug ci* Improve afl-cc (#1975)* update response file support - full support of rsp file - fix some segv issues* Improve afl-cc - remove dead code about allow/denylist options of sancov - missing `if (!aflcc->have_msan)` - add docs for each function - typo* enable nyx* debug ci* debug ci* debug ci* debug ci* debug ci* debug ci* debug ci* debug ci* fix ci* clean test script* NO_NYX* NO_NYX* fix ci* debug ci* fix ci* finalize ci fix* Enhancement on Deterministic stage (#1972)* fuzzer: init commit based on aflpp60dc37a* fuzzers: adding the skip variables and initialize* log: profile the det/havoc finding* log: add profile log output* fuzzers: sperate log/skipdet module* fuzzers: add quick eff_map calc* fuzzers: add skip_eff_map in fuzz_one* fuzzers: mark whole input space in eff_map* fuzzers: add undet bit threshold to skip some seeds* fuzzers: fix one byte overflow* fuzzers: fix overflow* fix code format* add havoc only again* code format* remove log to INTROSPECTION, rename skipdet module* rename skipdet module* remove log to stats* clean redundant code* code format* remove redundant code format check* remove redundant doc* remove redundant objects* clean files* change -d to default skipdet* disable deterministic when using CUSTOM_MUTATOR* revert fix* final touches for skipdet* remove unused var* remove redundant eff struct (#1977)* update QEMU-Nyx submodule (#1978)* update QEMU-Nyx submodule (#1980)* Fix type in AFL_NOOPT env variable in afl-cc help message (#1982)* nits* 2024 v4.10c release* fixes---------Signed-off-by: Xeonacid <h.dwwwwww@gmail.com>Co-authored-by: Sonic <50692172+SonicStark@users.noreply.github.com>Co-authored-by: Xeonacid <h.dwwwwww@gmail.com>Co-authored-by: Nils Bars <nils.bars@rub.de>Co-authored-by: Jean-Romain Garnier <7504819+JRomainG@users.noreply.github.com>Co-authored-by: Jean-Romain Garnier <jean-romain.garnier@airbus.com>Co-authored-by: Sergej Schumilo <sergej@schumilo.de>Co-authored-by: Christian Holler (:decoder) <choller@mozilla.com>Co-authored-by: Han Zheng <35988108+kdsjZh@users.noreply.github.com>Co-authored-by: Khaled Yakdan <yakdan@code-intelligence.com>
The submodule of unicorn cannot be imported through unicornafl.*_const here. If we want to use the *_const module, we should reference `from unicorn.*_const import *` like this instead of importing the entire contents of the *_const module via unicornafl。
@vanhauser-thcvanhauser-thc changed the base branch fromstable todevFebruary 19, 2024 08:20
@vanhauser-thc
Copy link
Member

@domenukk ?

@domenukk
Copy link
Member

I don't quite get this, we dofrom unicorn import * inside unicornafl, soin theory shouldn't the modules be there?
cc@wtdcode

@Resery
Copy link
ContributorAuthor

I don't quite get this, we dofrom unicorn import * inside unicornafl, soin theory shouldn't the modules be there? cc@wtdcode

Simple test:

Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linuxType "help", "copyright", "credits" or "license" for more information.>>> from unicornafl import *>>> from unicornafl.arm_const import *Traceback (most recent call last):  File "<stdin>", line 1, in <module>ModuleNotFoundError: No module named 'unicornafl.arm_const'>>>

The version of unicornafl:

$ python3 -m pip list | grep unicornaflunicornafl                    2.0.2

Sorry, upload img is too troublesome, so I use text.

@wtdcode
Copy link
Member

The fix is correct but notideal. Suggested fix:

try:fromunicornafl.x86_constimport*# compatibility with unicornafl v1exceptImportError:fromunicorn.x86_constimport*# v2

The root cause is that unicornafl2 removes the duplicate constant definitions totally because Unicorn2 is fast evolving with fixing missing constants.

@domenukk
Copy link
Member

The try except doesn't sound clean either? Is there a way to make this future-proof then?

@wtdcode
Copy link
Member

wtdcode commentedFeb 19, 2024
edited
Loading

To make it future-proof, this fix should be correct because unicornaflshall no longer duplicate defs itself.

@domenukk
Copy link
Member

Are you sure we won't end up with different unicornafl and unicorn libraries and it'll mess everything up?

@wtdcode
Copy link
Member

wtdcode commentedFeb 19, 2024 via email

Uncornafl (using uncorn2) will no longer ship these definitions as the author here suggests because it doesn’t make sense. Besides, Unicorn so far keeps ABI compatibility including enum values. In other words, even with unicornafl1+unicorn1, this fix should also work.
________________________________From: Dominik Maier ***@***.***>Sent: Tuesday, February 20, 2024 1:13:05 AMTo: AFLplusplus/AFLplusplus ***@***.***>Cc: lazymio ***@***.***>; Mention ***@***.***>Subject: Re: [AFLplusplus/AFLplusplus] replaced unicornafl with unicorn (PR#2003)Are you sure we won't end up with different unicornafl and unicorn libraries and it'll mess everything up?―Reply to this email directly, view it on GitHub<#2003 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULOYKE2BE6VQS7C6NL3LYUOB2DAVCNFSM6AAAAABDN6GZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHEYDGNRTGU>.You are receiving this because you were mentioned.Message ID: ***@***.***>

@domenukkdomenukk merged commit7307131 intoAFLplusplus:devFeb 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Resery@vanhauser-thc@domenukk@wtdcode

[8]ページ先頭

©2009-2025 Movatter.jp