Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify retrieval of collections.all ingetLocaleCollectionItem#3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
noelforte wants to merge3 commits into11ty:main
base:main
Choose a base branch
Loading
fromnoelforte:i18n-page-resolution

Conversation

@noelforte
Copy link
Contributor

@noelfortenoelforte commentedApr 28, 2025
edited
Loading

This change motivated by:noelforte/eleventy-plugin-vento#221

I couldn't figure out why the i18n plugin's presence was breaking thegetNextCollectionItem andgetPreviousCollectionItem filters since the Vento template engine plugin doesn't do anything fancy with the filters.

After a lot of trial and error, I discovered that this search for collections.all at the very end of theGetLocaleCollectionItem module checks a lot of things specific to Eleventy's own internal engines but of course custom engines don't add actx orcontext object, or eventhis.collections, sincethis.page andthis.eleventy are the only context keys Eleventy supports, andcollections is already accessible in page data anyway.

Rather than addthis.collections to the Vento custom engine, could we simplify theall declaration to search thedata key instead since thedata key is already available on the render context anyway?

If not, I can look into addingthis.collections to the custom engine for my plugin, but if this can be handled upstream that puts less pressure on custom engines to support adding it.

Thanks Zach!

helenclx and xplosionmind reacted with thumbs up emojixplosionmind reacted with heart emojixplosionmind reacted with eyes emoji
@noelforte
Copy link
ContributorAuthor

noelforte commentedMay 30, 2025
edited
Loading

Sorry to bug you Zach, any inclination on when this might get reviewed? Is there something that I could do to help push things along?

@noelforte
Copy link
ContributorAuthor

@zachleat Just confirming, is this PR on hold for a specific reason? It's not been tagged ason-hold, and also I haven't heard anything about getting this reviewed apart from one reference in#2844. I know you're busy but I'd like to know whether I should be implementing a workaround on my own or whether the 11ty codebase can adapt these changes.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zachleatzachleatAwaiting requested review from zachleatzachleat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@noelforte

[8]ページ先頭

©2009-2025 Movatter.jp