Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: No longer instantiate a dependency if it has been explicitly passed#307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
remimd merged 3 commits intodevfrominject
Dec 6, 2025

Conversation

@remimd
Copy link
Member

No description provided.

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR modifies the dependency injection mechanism to prevent instantiating dependencies when they have been explicitly passed as arguments to an injected function. The implementation introduces an exclusion system that filters out dependencies whose parameters are already bound.

Key Changes

  • Modified theDependencies class to accept anexclude parameter, filtering out dependencies by parameter name
  • Refactoredbind andabind methods to first bind explicit arguments, then retrieve only non-excluded dependencies
  • Simplified the argument binding logic by separating concerns into__bind and__build_arguments methods

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@remimdremimd changed the titleNo longer instantiate a dependency if it has been explicitly passedfeat: No longer instantiate a dependency if it has been explicitly passedDec 6, 2025
@remimdremimd merged commit7af0fdd intodevDec 6, 2025
6 checks passed
@remimdremimd deleted the inject branchDecember 6, 2025 11:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

@remimdremimd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remimd

[8]ページ先頭

©2009-2025 Movatter.jp