Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork0
feat: No longer instantiate a dependency if it has been explicitly passed#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR modifies the dependency injection mechanism to prevent instantiating dependencies when they have been explicitly passed as arguments to an injected function. The implementation introduces an exclusion system that filters out dependencies whose parameters are already bound.
Key Changes
- Modified the
Dependenciesclass to accept anexcludeparameter, filtering out dependencies by parameter name - Refactored
bindandabindmethods to first bind explicit arguments, then retrieve only non-excluded dependencies - Simplified the argument binding logic by separating concerns into
__bindand__build_argumentsmethods
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
7af0fdd intodevUh oh!
There was an error while loading.Please reload this page.
No description provided.