Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork0
refactor: Now analyze the types at the module level#297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR refactors the dependency injection framework to move type analysis logic from theLocator class to theModule class, creating a cleaner separation of concerns. TheLocator now simply stores and retrieves injectables by exact key match, while theModule handles all type expansion and matching operations.
Key Changes:
- Moved type expansion logic from
LocatortoModuleby introducingModule.__build_key_types()andModule.__matching_key_types() - Simplified
Locator.__getitem__()andLocator.__contains__()to perform direct lookups without type expansion - Replaced
Updater.with_basics()withModule.update_from()to centralize type analysis at the Module level
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ccf7e85 intodevUh oh!
There was an error while loading.Please reload this page.
No description provided.