Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: Now analyze the types at the module level#297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
remimd merged 2 commits intodevfromperf
Nov 24, 2025
Merged

Conversation

@remimd
Copy link
Member

No description provided.

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR refactors the dependency injection framework to move type analysis logic from theLocator class to theModule class, creating a cleaner separation of concerns. TheLocator now simply stores and retrieves injectables by exact key match, while theModule handles all type expansion and matching operations.

Key Changes:

  • Moved type expansion logic fromLocator toModule by introducingModule.__build_key_types() andModule.__matching_key_types()
  • SimplifiedLocator.__getitem__() andLocator.__contains__() to perform direct lookups without type expansion
  • ReplacedUpdater.with_basics() withModule.update_from() to centralize type analysis at the Module level

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@remimdremimd merged commitccf7e85 intodevNov 24, 2025
6 checks passed
@remimdremimd deleted the perf branchNovember 24, 2025 13:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

@remimdremimd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remimd

[8]ページ先頭

©2009-2025 Movatter.jp