Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updated Poland Country Code#1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
profnandaa merged 4 commits intovalidatorjs:masterfromRonqn:master
Oct 30, 2021
Merged

Updated Poland Country Code#1809

profnandaa merged 4 commits intovalidatorjs:masterfromRonqn:master
Oct 30, 2021

Conversation

Ronqn
Copy link
Contributor

@RonqnRonqn commentedOct 19, 2021•
edited
Loading

Updated the country code of Poland from PO to PL.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Fixes#1806

EDIT : First check failed because I forgot to edit the validator.js file. All good now!
EDIT 2 : Also updated README.md... my bad

@codecov
Copy link

codecovbot commentedOct 19, 2021•
edited
Loading

Codecov Report

Merging#1809 (a08e1bb) intomaster (13651ea) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1809   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          102       102             Lines         2029      2029             Branches       457       457           =========================================  Hits          2029      2029
Impacted FilesCoverage Δ
src/lib/isPassportNumber.js100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update13651ea...a08e1bb. Read thecomment docs.

Copy link
Member

@tux-tntux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for your PR@Ronqn ! Mostly LGTM. Please check and address my comment!

Copy link
Member

@tux-tntux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🎉 ! Don't know why github showed my an old revision of yourREADME.md

@tux-tntux-tn added ready-to-landFor PRs that are reviewed and ready to be landed 🎉 first-pr hacktoberfest-accepted labelsOct 19, 2021
@Ronqn
Copy link
ContributorAuthor

Thanks for accepting, I noticed the typo after replacing and quickly fixed it, the check probably bugged at that time :-)

👍🏻

Copy link
Member

@profnandaaprofnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the catch! 🎉

@profnandaaprofnandaa merged commita837e6f intovalidatorjs:masterOct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull requestOct 30, 2021
* Updated Poland Country Code* Updated PO to PL in validator.js* Changed PO to PL in README.md* Typo in README.mdCo-authored-by: Ronan Doudiès <rondou@eptm-it.ch>
profnandaa pushed a commit that referenced this pull requestOct 31, 2021
* Updated Poland Country Code* Updated PO to PL in validator.js* Changed PO to PL in README.md* Typo in README.mdCo-authored-by: Ronan Doudiès <rondou@eptm-it.ch>
profnandaa pushed a commit that referenced this pull requestOct 31, 2021
* Updated Poland Country Code* Updated PO to PL in validator.js* Changed PO to PL in README.md* Typo in README.mdCo-authored-by: Ronan Doudiès <rondou@eptm-it.ch>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes

@tux-tntux-tntux-tn approved these changes

Assignees

No one assigned

Labels

🎉 first-prhacktoberfest-acceptedready-to-landFor PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid country code for Poland

3 participants

@Ronqn@profnandaa@tux-tn
[8]ページ先頭
©2009-2025 Movatter.jp