Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(isPostalCode): AddLK (Sri Lanka) locale#1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nimanthadilz
Copy link
Contributor

AddedLK locale toisPostalCode validator. Tests are provided.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecovbot commentedOct 14, 2021

Codecov Report

Merging#1788 (8201312) intomaster (13651ea) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##            master     #1788   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files          102       102             Lines         2029      2029             Branches       457       457           =========================================  Hits          2029      2029
Impacted FilesCoverage Δ
src/lib/isPostalCode.js100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update13651ea...8201312. Read thecomment docs.

Copy link
Member

@tux-tntux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thank you for your PR@nimanthadilz 🎉
Is your contribution as part of Hacktoberfest?

@tux-tntux-tn added ready-to-landFor PRs that are reviewed and ready to be landed 🎉 first-pr labelsOct 25, 2021
@nimanthadilz
Copy link
ContributorAuthor

@tux-tn Yes. I did this contribution as part of Hacktoberfest.

Copy link
Member

@profnandaaprofnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for your contrib! 🎉

@profnandaaprofnandaa merged commit8451206 intovalidatorjs:masterOct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull requestOct 30, 2021
* Add `LK` locale to `isPostalCode`* Add tests for `LK` locale of `isPostalCode`* Update README.md
profnandaa pushed a commit that referenced this pull requestOct 31, 2021
* Add `LK` locale to `isPostalCode`* Add tests for `LK` locale of `isPostalCode`* Update README.md
profnandaa pushed a commit that referenced this pull requestOct 31, 2021
* Add `LK` locale to `isPostalCode`* Add tests for `LK` locale of `isPostalCode`* Update README.md
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@profnandaaprofnandaaprofnandaa approved these changes

@tux-tntux-tntux-tn approved these changes

Assignees

No one assigned

Labels

🎉 first-prhacktoberfest-acceptedready-to-landFor PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nimanthadilz@profnandaa@tux-tn
[8]ページ先頭
©2009-2025 Movatter.jp