- Notifications
You must be signed in to change notification settings - Fork3k
Bug fix: includesos package import in root command generation#1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <jmcbride@vmware.com>
Closed
marckhouzam approved these changesDec 9, 2021
Actually hold on, I'm trying to reproduce and I'm having problems. Give me a few minutes |
Looks good@jpmcb thanks for fixing. I was able to reproduce the problem on the master branch and show that it doesn't happen with this PR. |
Yeah - it was a really tricky one to reproduce and is buried pretty deep in the generation stuff. Thanks for the review!! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a missing
osimport in the root command generation after1beb476 was merged. This prevented the default boilerplate from being buildableCloses:#1556