Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(touch): add coverage for -d option#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nfischer merged 1 commit intomasterfromtest-touch-date
Jan 4, 2019
Merged

Conversation

nfischer
Copy link
Member

No change to production logic.

We never had coverage fortouch({'-d': ...}), so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of theDate type.

Test:handles date argument case

No change to production logic.We never had coverage for `touch({'-d': ...})`, so this adds testcoverage. This also updates documentation to clarify the parametershould be an instance of the `Date` type.Test: `handles date argument` case
@codecov-io
Copy link

Codecov Report

Merging#925 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #925   +/-   ##=======================================  Coverage   97.26%   97.26%           =======================================  Files          34       34             Lines        1281     1281           =======================================  Hits         1246     1246             Misses         35       35
Impacted FilesCoverage Δ
src/touch.js100% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update355287e...e1fb25a. Read thecomment docs.

@nfischer
Copy link
MemberAuthor

This was covered by somecp.js tests, but it's probably clearer to put a test intouch.js anyway.

@nfischernfischer merged commit5371e16 intomasterJan 4, 2019
@nfischernfischer deleted the test-touch-date branchJanuary 4, 2019 10:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nfischer@codecov-io

[8]ページ先頭

©2009-2025 Movatter.jp