@nfischer
The failure is on those other two test cases on line 39 and 48; seems to be returning both the original error, and the new one, even with that explicit return.

   38:   t.truthy(shell.error());                                             39:   t.is(result.stderr, 'grep: no such file or directory: /asdfasdf');   40:   t.is(result.code, 2);                                               Difference:  - `grep: no such file or directory: /asdfasdf␊  - grep: `  + `grep: no such file or directory: /asdfasdf

@wyardley can you add "Fixes#900" to the PR description?

@nfischer Ok, how's that look. I added another test case for the specific case where there are two files, one which dne and the other of which doesn't match. I can move this to the "Invalids" section if you think that's better (see above)...

Codecov Report

Merging#901 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #901      +/-   ##==========================================+ Coverage   97.32%   97.32%   +<.01%==========================================  Files          34       34                Lines        1269     1271       +2     ==========================================+ Hits         1235     1237       +2  Misses         34       34

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6b3c7b1...163e049. Read thecomment docs.

@nfischer applied your suggestions and squashed

Thanks. I'll merge this after I push a release (this probably constitutes a breaking change).

Hi. This fix is still not available on the latest releasev0.8.4, despite being on the master branch (https://github.com/shelljs/shelljs/blob/master/src/grep.js#L72-L75). What is its status? Was there an issue with its packaging? This fix is really needed, as the current grep implementation is broken - I would argue it's a fixing change rather than a breaking one, as anyone relying on exit code 1 to detect the absence of matches is currently broken. Thanks.

I think this landed after v0.8.3 went out. v0.8.4 was a small patch release for a specific bug, which is why this didn't make it in that release either.

I've updated the milestone field to clarify this is expected to be part of v0.9.0. I haven't had time to figure out what needs to make it in that release and what should be punted to the next release.

@nfischer Thanks for the quick reply. Any idea when v0.9.0 might be released? It's been over 2 years now since this fix, so I'll have to use another script in the mean time.