Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor Consumer Group to use Client#947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rhansen2
Copy link
Collaborator

No description provided.

ppd0705 reacted with thumbs up emoji
@rhansen2rhansen2 changed the base branch frommain to0.5July 8, 2022 20:38
@rhansen2rhansen2force-pushed theconsumer-group-client branch from5b9359c to52863f0CompareJuly 14, 2022 04:30
@rhansen2rhansen2 marked this pull request as ready for reviewJuly 29, 2022 02:27
Copy link
Contributor

@achille-rousselachille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We discussed the PR during our team meeting today and agreed on making the following changes:

  • base the change on the 0.4 branch since it contains minor modifications to the exported APIs (removed an unused field + change fields fromint32 toint types)
  • explore passing a parent context to the methods of thecoordinator interface
  • add theAllowAutoTopicCreation field to the top levelMetadataRequest type so we don't need to bypass the abstraction layers

@rhansen2rhansen2 changed the base branch from0.5 tomainAugust 25, 2022 04:22
Copy link
Contributor

@achille-rousselachille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking ready to merge in my opinion 🙌

@achille-rousselachille-roussel merged commitee37c7f intosegmentio:mainSep 12, 2022
@rhansen2rhansen2 deleted the consumer-group-client branchOctober 21, 2022 18:38
@moolitayer
Copy link

Hi@rhansen2@achille-roussel,

Thank you for working on this awsome library!

Recently we've seen an issue on upgrading from v0.4.35 to v0.4.36. The issue went away after downgrad:

Failed to join X: [79] Member ID Required: the group member needs to have a valid member id before actually entering a consumer groupFailed to join group X: kafka.(*Client).JoinGroup: unexpected EOFFailed to sync group X: kafka.(*Client).SyncGroup: unexpected EOFFailed to sync group X: [27] Rebalance In Progress: the coordinator has begun rebalancing the group, the client should rejoin the groupkafka.(*Client).SyncGroup: unexpected EOF

Do you think it might be ralted to this change? Should I create an issue for it with our env details + code?

@rhansen2
Copy link
CollaboratorAuthor

Could be related. Please open an issue and we'll take a look, thanks!

@jhartzell
Copy link

Hi@rhansen2@achille-roussel,

Thank you for working on this awsome library!

Recently we've seen an issue on upgrading from v0.4.35 to v0.4.36. The issue went away after downgrad:

Failed to join X: [79] Member ID Required: the group member needs to have a valid member id before actually entering a consumer groupFailed to join group X: kafka.(*Client).JoinGroup: unexpected EOFFailed to sync group X: kafka.(*Client).SyncGroup: unexpected EOFFailed to sync group X: [27] Rebalance In Progress: the coordinator has begun rebalancing the group, the client should rejoin the groupkafka.(*Client).SyncGroup: unexpected EOF

Do you think it might be ralted to this change? Should I create an issue for it with our env details + code?

Also seeing the same issue under a Strimzi cluster

@rhansen2
Copy link
CollaboratorAuthor

@moolitayer or@jhartzell Are either of you able to create an issue with a reproduction of the issues you're seeing?

@rhansen2
Copy link
CollaboratorAuthor

@moolitayer@jhartzell
While not exactly what you're seeing, I did find a potential source of unexpected EOFs. Would you be able to try outhttps://github.com/rhansen2/kafka-go/tree/join-group-meta-parsing and see if that changes anything for you?

Thanks!

rhansen2 added a commit to rhansen2/kafka-go that referenced this pull requestNov 9, 2022
rhansen2 added a commit that referenced this pull requestNov 9, 2022
* Revert "Fixes for consumer group (#1022)"This reverts commita5f270d.* Revert "Refactor Consumer Group to use Client (#947)"This reverts commitee37c7f.
@rhansen2rhansen2 restored the consumer-group-client branchNovember 9, 2022 01:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@achille-rousselachille-rousselachille-roussel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhansen2@moolitayer@jhartzell@achille-roussel
[8]ページ先頭
©2009-2025 Movatter.jp