attn@filipesilva ... we're getting errors fromcheck-side-effects, however, there's no real change to the tree-shakability of what rxjs is outputting here from any of my tests (with angular-cli).

It does have me a little concerned thatrollup will have issues with this. Good grief, I had modules.@Rich-Harris, should rollup not like what we're doing here? It's admittedly bananas, but it seems to be working otherwise.

Yeah, I don't think we can get this fix into version 7 unless we're totally sure it's in the clear with everyone's bundlers. This isonly to fix auto imports in VS Code... as crazy as that is. So just waiting to have some experts weigh in.

Hopefully we don't need to restructure our entire build to get things working in VS Code. :\

FWIW, I did a small test with Rollup and the inclusion of the imports seems to make no difference to its output and tree shaking seems to work just fine.

Unfortunately I got different results. I added atmp/index.js file with a single line:

import'../dist/esm5_for_rollup/index.js';

Running the following onmaster afternpm run compile...

npx rollup@latest -i tmp/index.js -o tmp/master.js -f esm

...yielded a 48kb (unminified) file.

I switched to this branch and it failed at first, becausedist/esm5_for_rollup/index.js contained the new directory imports...

import'./ajax';import'./fetch';import'./operators';import'./testing';import'./webSocket';

...which Rollup chafes at (since native loaders don't handle directory imports). Appending/index.js to each of the imports allowed the command to run, but it yielded a 91kb file.

Thank you so much,@Rich-Harris, for taking the time to look at this.

So given this feedback, I think this PR is a no-go, and I'm going to close it. We're going to have to come up with another solution.

All right, I've reopened this because there was another approach proposed by the TypeScript team, and it seems to be working! cc@cartant

I've tested this with the methodology recommended by@Rich-Harris, and the output is identical between this branch and the master branch. So I think this is good to go.