- Notifications
You must be signed in to change notification settings - Fork3k
docs(versioning): add versioning to docs website#5793
docs(versioning): add versioning to docs website#5793niklas-wortmann merged 1 commit intoReactiveX:6.xfrom
Conversation
| "rxjs-dev": { | ||
| "hosting": { | ||
| "stable": [ | ||
| "rxjs-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't actually know much about this configuration. Can you explain what this is doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sure, so we have one firebase project called rxjs-dev, we only use the hosting feature of firebase. Within firebase though we host now one "site" per version and those get an alias. So if you dofirebase deploy --only hosting:stable it will deploy the current dist folder in the stable site. It's kinda like an alias for the site that is used within this branch
benlesh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Rebase and merge when you're ready.
I think the failure on the "latest" build is expected and we need to figure out how to make it optional on the 6.x branch. 🤔
No description provided.