Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed set_variation_by_name offset#6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython-pillow:mainfromradarhere:set_variation_by_name
Oct 28, 2022

Conversation

radarhere
Copy link
Member

Resolves#6439

When callingFT_Set_Named_Instance, the index starts at 1.

https://freetype.org/freetype2/docs/reference/ft2-multiple_masters.html#ft_set_named_instance

The index of the requested instance, starting with value 1.

Apparently in#3802, I presumed it started at zero, leading to the wrong variation being selected.

index=names.index(name)

@nulano
Copy link
Contributor

Instead of increasing the epsilon so much, would it be better to modifyvariation_adobe_older_harfbuzz_name.png instead?

You can grab the image rendered on the CI from theerrors artifact of the failed build, looks likea.png fromtmpqztw6w8z is the correct replacement, attached below:

a

@radarhere
Copy link
MemberAuthor

To be clear - I have implemented the suggestion from@nulano, and then he approved that.

hugovk and nulano reacted with thumbs up emoji

@hugovkhugovk merged commit31f66ea intopython-pillow:mainOct 28, 2022
@radarhereradarhere deleted the set_variation_by_name branchOctober 28, 2022 10:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nulanonulanonulano approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theset_variation_by_name method ofFreeTypeFont is inconsistent with the result
3 participants
@radarhere@nulano@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp