- Notifications
You must be signed in to change notification settings - Fork96
Allow non-TTY stdin watch mode#448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The presence of stdin doesn't necessarily mean there's an allocatedtty. This breaks watch mode in non-TTY stdin contexts (e.g. docker,foreman, etc). A simple process.stdin.isTTY check would theoreticallybe enough but unfortunately, subprocesses don't have the same API,which are used extensively to test via calls to `spawn`.A simple solution is to inject an env var dependency where we tellthe process that it's indeed a TTY-allocated process and so, watch modewith exit handling is good to go.
This was referencedNov 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of stdin doesn't necessarily mean there's an allocated tty. This breaks watch mode in non-TTY stdin contexts (e.g. docker, foreman, etc). A simple process.stdin.isTTY check would theoretically be enough but unfortunately, subprocesses don't have the same API, and they are used extensively for testing via calls to the function
spawn.A simple solution is to inject an env var dependency where we tell the process that it's indeed a TTY-allocated process and so, watch mode with exit handling is good to go.
A more robust but also annoying solution would involve using an actual terminal emulator (likeMicrosoft's node-pty). Though the environment gets exponentially more difficult to setup since it
involves compiling bindings, which require different requirements per OS.
Closes#424