- Notifications
You must be signed in to change notification settings - Fork96
Add support fordir-dependency messages#383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedMay 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry so long in getting around to reviewing this; time flies.
This needs tests, also one nitpick.
Uh oh!
There was an error while loading.Please reload this page.
No problem@RyanZim, thanks for taking a look! I have added some tests now 👍 |
This extendspostcss#383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
This extends#383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
This PR adds support for
dir-dependencymessages.Directory dependencies are added to the dependency graph in the same way that files are. Chokidar accepts directories and will watch them recursively. Then, when a file changes we determine the "recompile" list by finding the dependants of each of the files ancestor directories.
Any questions or concerns let me know 👍