Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Error when using unsupported PostCSS version (#361)#362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

thinkverse
Copy link
Contributor

Added thepostcss version check@ai talked about. Changed the wording a bit and used the built-inerror function.

As for testing this functionality, not going to lie. I couldn't get this error to throw ones, even did the steps mentioned in the issue (#361) by usingnpm link to this version and installing plugins that usePostCSS 7 and it builds the CSS file and didn't throw a single error.

Seems like this error might be thrown very rarely? But I do hope it helps in the long run. 🙂

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.41% when pullinge140a29 on thinkverse:unsupported-postcss-version-error into4b9b66d on postcss:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.41% when pullinge140a29 on thinkverse:unsupported-postcss-version-error into4b9b66d on postcss:master.

@ai
Copy link
Member

ai commentedDec 7, 2020

@RyanZim this PR is ready to merge. Myyarn/npm error message suggestion is not a blocker to merge and release it (especially since a lot of users have this problem right now).

@thinkverse
Copy link
ContributorAuthor

I tried to find a good solution to the auto-discovery of the package manager but to no avail. Could keep looking for a solution for a later PR though of the feature is really needed.

@RyanZim
Copy link
Collaborator

KISS; no need for any fancy auto-detection. LGTM

@RyanZimRyanZim merged commit96b6521 intopostcss:masterDec 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aiaiai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@thinkverse@coveralls@ai@RyanZim
[8]ページ先頭
©2009-2025 Movatter.jp