NotificationsYou must be signed in to change notification settings
Fork96
Star856

Use 'slash' on input files before globbing to support absolute paths with backslashes on Windows#355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

RyanZim merged 1 commit intopostcss:masterfrommatthias-christen:master

Oct 20, 2020

Merged

Use 'slash' on input files before globbing to support absolute paths with backslashes on Windows#355

RyanZim merged 1 commit intopostcss:masterfrommatthias-christen:master

Oct 20, 2020

Conversation

Copy link

Contributor

matthias-christen commentedOct 16, 2020

globby (used to glob input arguments to postcss-cli) only supports forward slashes.
In order to be able to provide absolute paths containing backslashes to the CLI on Windows, they need to be converted to forward slashes, otherwise postcss-cli terminates with the error message 'Input Error: You must pass a valid list of files to parse'.

Use 'slash' on input files before globbing to support absolute paths …

a0d4fb0

…with backslashes on Windows

Copy link

coveralls commentedOct 16, 2020

Coverage increased (+0.1%) to 82.237% when pullinga0d4fb0 on matthias-christen:master intoc94c188 on postcss:master.

Copy link

Collaborator

RyanZim commentedOct 17, 2020

Forgive me for my ignorance (I've never actually run postcss on Windows), but why can't you just pass paths with forward slashes from the CLI?

Copy link

ContributorAuthor

matthias-christen commentedOct 19, 2020•
edited
Loading

@RyanZim, on Windows, the natural directory separator is a backslash. For instance, if you tab-autocomplete a path in a Windows command line, it will convert forward slashes to backslashes. So, in particular for a command line tool, I think it is important to accept paths in the system's standard format.
What is really confusing currently: if you supply a (seemingly) perfectly valid absolute path to postcss, you'll get the error message "Input Error: You must pass a valid list of files to parse". I guess you could also adjust the error message that the user must enter forward slashes, but why not just do it right when the fix is so simple.