- Notifications
You must be signed in to change notification settings - Fork89
simplify the regular expression for shortcut matching#76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
isaacs commentedJan 28, 2021
LGTM! |
nlf added a commit that referenced this pull requestJan 28, 2021
kasicka commentedApr 6, 2021
Should this be ported to to v2.x, which is still used by npm v6.x? |
nlf added a commit that referenced this pull requestApr 7, 2021
nlf added a commit that referenced this pull requestApr 7, 2021
nlf added a commit that referenced this pull requestApr 7, 2021
PR-URL:#84Credit:@nlfClose:#84Reviewed-by:@wraithgar
jeherve added a commit to Automattic/jetpack that referenced this pull requestMay 10, 2021
Closes#19787For more information:-npm/hosted-git-info#76
This was referencedMay 11, 2021
OS-WS commentedJun 22, 2021
Hi, WasCVE-2021-29063 fixed? Thanks in advance! |
West120912 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
G
This was referencedMay 6, 2022
This was referencedMar 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just removing a bunch of unnecessary complexity from regular expressions where i can