fix: Do not pass scp-style URLs to the WhatWG url.URL#62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

isaacs wants to merge2 commits intolegacy-ayfkmfromisaacs/fix-60-legacy

Closed

fix: Do not pass scp-style URLs to the WhatWG url.URL#62

isaacs wants to merge2 commits intolegacy-ayfkmfromisaacs/fix-60-legacy

Conversation

Copy link

Contributor

isaacs commentedFeb 26, 2020•
edited
Loading

Fix#60 (for the legacy branch)
Fix#61

fix: Do not pass scp-style URLs to the WhatWG url.URL

f2cdfcf

Fix#60 (for the legacy branch)

isaacs requested a review fromdarcyclarke

February 26, 2020 22:22

fix: Do not attempt to use url.URL when unavailable

bb123d2

Fix#61This should not be ported to the latest branch, as Node.js v6 supportwas dropped there anyway.

Copy link

billneff79 commentedFeb 26, 2020

@isaacs - I put forward an alternative fix in PR#64 that gets rid of url.URL all together. I don't care which gets merged, as long as one of the fixes does

This was referencedFeb 26, 2020

fix: Do not pass scp-style URLs to the WhatWG url.URL#63

Closed

fix: do not use url.URL to support early node 6 and scp-style URLs#64

Closed

isaacs added a commit that referenced this pull request

Feb 26, 2020

fix: Do not attempt to use url.URL when unavailable

2d0bb66

Fix#61This should not be ported to the latest branch, as Node.js v6 supportwas dropped there anyway.PR-URL:#62Credit:@isaacsClose:#62Reviewed-by:@isaacs