Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update transport.js#2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
beatfactor merged 2 commits intonightwatchjs:mainfromTopperfalkon:feature/appium-null-browser-fix
Sep 12, 2021
Merged

Update transport.js#2882

beatfactor merged 2 commits intonightwatchjs:mainfromTopperfalkon:feature/appium-null-browser-fix
Sep 12, 2021

Conversation

Topperfalkon
Copy link
Contributor

Appium can get upset if you supply both a browserName and an appPackage as desiredCapabilities at the same time.

A brief reading of an Appium issue report from a few years ago suggests itshouldn't complain, but this will fix the current behaviour to allow users to set a null browser

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Should resolve an issue raised in discussion#2881

Appium can get upset if you supply both a browserName and an appPackage as desiredCapabilities at the same time.A brief reading of an Appium issue report from a few years ago suggests it _shouldn't_ complain, but this will fix the current behaviour to allow users to set a null browser
@CLAassistant
Copy link

CLAassistant commentedAug 27, 2021•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@beatfactor
Copy link
Member

Thanks for submitting this. Does this cover it?

@Topperfalkon
Copy link
ContributorAuthor

Yeah, turned out a lot simpler than I thought 😄

So, now, if you pass throughbrowserName: null, in your suite's config, this should just pass all the way through without error. Before it was falling into thebrowserName.toLowerCase() operation and erroring.

I had a brief look at the v2 branch and Ithink that'll have a similar problem, but that area's changed quite a bit so I haven't attempted a fix on that branch

@Topperfalkon
Copy link
ContributorAuthor

@beatfactor do you need anything else from me on this one? It seems to just be waiting for another reviewer

@beatfactor
Copy link
Member

A small test will be needed. I'll merge it in soon.

Topperfalkon reacted with thumbs up emoji

@beatfactorbeatfactor merged commitd2fd8ba intonightwatchjs:mainSep 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@beatfactorbeatfactorbeatfactor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Topperfalkon@CLAassistant@beatfactor
[8]ページ先頭
©2009-2025 Movatter.jp