- Notifications
You must be signed in to change notification settings - Fork144
Conversation
ContributorAuthor
rbuckton commentedJun 11, 2021
Can someone review please? We would need to ship an updated |
DanielRosenwasser approved these changesJun 11, 2021
ContributorAuthor
rbuckton commentedJun 11, 2021
@DanielRosenwasser can you let me know when this is published? As far as versioning is concerned, this is a backwards compatible change (the only slight difference would be for |
Member
DanielRosenwasser commentedJun 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@rbuckton it sounds like for any existing user (ignoring people manually writing out weird references to tslib), this is backwards-compatible. Otherwise, it's just enabling TypeScript 4.4 to make a breaking change. Is that accurate? |
Member
DanielRosenwasser commentedJun 11, 2021
I'm going to version this as 2.3.0. |
ContributorAuthor
rbuckton commentedJun 11, 2021
Its not even a breaking change. TS 4.4 would work with old tslib, but would be slower and have the older incorrect array-packing behavior, and TS 4.3 will work with the new tslib and likely be faster but mostly maintaining the older incorrect array-packing behavior. |
Member
DanielRosenwasser commentedJun 11, 2021
2.3.0 should be available shortly. |
This was referencedJun 11, 2021
Closed
This was referencedJul 2, 2021
1 task
1 task
This was referencedJul 8, 2021
1 task
This was referencedJul 18, 2021
This was referencedJul 25, 2021
This was referencedAug 5, 2021
jcfranco referenced this pull request in Esri/calcite-design-systemJul 16, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [tslib](https://www.typescriptlang.org/)([source](https://togithub.com/Microsoft/tslib)) | [`2.6.2` ->`2.6.3`](https://renovatebot.com/diffs/npm/tslib/1.14.1/2.6.3) |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>Microsoft/tslib (tslib)</summary>### [`v2.6.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.3)[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.6.2...v2.6.3)#### What's Changed- 'await using' normative changes by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/258](https://togithub.com/microsoft/tslib/pull/258)**Full Changelog**:microsoft/tslib@v2.6.2...v2.6.3###[`v2.6.2`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.2):tslib 2.6.2[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.6.1...v2.6.2)#### What's Changed- Fix path to `exports["module"]["types"]` by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/217](https://togithub.com/microsoft/tslib/pull/217)**Full Changelog**:microsoft/tslib@v2.6.1...v2.6.2###[`v2.6.1`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.1):tslib 2.6.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.6.0...v2.6.1)#### What's Changed- Allow functions as values in \__addDisposableResource by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/215](https://togithub.com/microsoft/tslib/pull/215)- Stop using es6 syntax in the es6 file by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/216](https://togithub.com/microsoft/tslib/pull/216)**Full Changelog**:microsoft/tslib@2.6.0...v2.6.1### [`v2.6.0`](https://togithub.com/microsoft/tslib/releases/tag/2.6.0):tslib 2.6.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.5.3...2.6.0)#### What's Changed- Add helpers for `using` and `await using` by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/213](https://togithub.com/microsoft/tslib/pull/213)**Full Changelog**:microsoft/tslib@v2.5.3...2.6.0###[`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3):tslib 2.5.3[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3)#### What's Changed- Do not reference tslib.es6.js from package.json exports by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208)**Full Changelog**:microsoft/tslib@2.5.2...v2.5.3### [`v2.5.2`](https://togithub.com/microsoft/tslib/releases/tag/2.5.2):tslib 2.5.2[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.1...2.5.2)This release [explicitly re-exportshelpers](https://togithub.com/microsoft/tslib/pull/204) to work aroundTypeScript's incomplete symbol resolution for tslib.### [`v2.5.1`](https://togithub.com/microsoft/tslib/releases/tag/2.5.1):tslib 2.5.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.0...2.5.1)This release of tslib provides fixes for two issues.First, [it reverses the order of `init` hooks provided bydecorators](https://togithub.com/microsoft/tslib/pull/202) to correctlyreflect proposed behavior.Second, it [corrects the `exports` field of tslib's `package.json` andprovides accurate declarationfiles](https://togithub.com/microsoft/tslib/pull/202) so that it may beconsumed under the `node16` and `bundler` settings for`moduleResolution.`### [`v2.5.0`](https://togithub.com/microsoft/tslib/releases/tag/2.5.0):tslib 2.5.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.4.1...2.5.0)#### What's New- Fix asyncDelegator reporting done too early by[@​apendua](https://togithub.com/apendua) in[https://github.com/microsoft/tslib/pull/187](https://togithub.com/microsoft/tslib/pull/187)- Add support for TypeScript 5.0's `__esDecorate` and related helpers by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/193](https://togithub.com/microsoft/tslib/pull/193)**Full Changelog**:microsoft/tslib@2.4.1...2.5.0### [`v2.4.1`](https://togithub.com/microsoft/tslib/releases/tag/2.4.1):tslib 2.4.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.4.0...2.4.1)This release contains [fixes for early `return`s and `throw`s invoked ongenerators](https://togithub.com/microsoft/tslib/pull/186).### [`v2.4.0`](https://togithub.com/microsoft/tslib/releases/tag/2.4.0):tslib 2.4.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.3.1...2.4.0)This release includes the `__classPrivateFieldIn` helper as well as anupdate to `__createBinding` to reduce indirection between multiplere-exports.### [`v2.3.1`](https://togithub.com/microsoft/tslib/releases/tag/2.3.1):tslib 2.3.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1)This release updates the `__spreadArray` helper for TypeScript 4.4 tocorrectly operate on collections that are not "concat-spreadable" suchas the DOM's `NodeList`s and `HTMLCollection`s.### [`v2.3.0`](https://togithub.com/microsoft/tslib/releases/tag/2.3.0):tslib 2.3.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0)This release updates tslib to use TypeScript 4.4's upcoming`__spreadArray` helper which correctly preserves sparse array inputs(e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This newversion of `__spreadArray` is backwards-compatible and is often alsofaster. See[https://github.com/microsoft/tslib/pull/151](https://togithub.com/microsoft/tslib/pull/151)for more details.### [`v2.2.0`](https://togithub.com/microsoft/tslib/releases/tag/2.2.0):tslib 2.2.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0)This release supports TypeScript 4.3's new functionality for ECMAScriptprivate methods and accessors, and private static class members.It does so by expanding the scope of `__classPrivateFieldGet` and`__classPrivateFieldSet`. See[https://github.com/microsoft/tslib/pull/146](https://togithub.com/microsoft/tslib/pull/146)for more details.### [`v2.1.0`](https://togithub.com/microsoft/tslib/releases/tag/2.1.0):tslib 2.1.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.3...2.1.0)This release adds a new `__spreadArray` helper which avoids side-effectscompared to the now-deprecated `__spreadArrays` and `__spread` helpers.See[https://github.com/microsoft/tslib/pull/133](https://togithub.com/microsoft/tslib/pull/133)for more details.This release also provides a more-specific error message when extendingfrom a type which is not a function and not null. See[https://github.com/microsoft/tslib/pull/138](https://togithub.com/microsoft/tslib/pull/138)for more details.### [`v2.0.3`](https://togithub.com/microsoft/tslib/releases/tag/2.0.3):Webpack 5 Compatibility - 2.x[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.2...2.0.3)Full discussion in the [webpackissue](https://togithub.com/webpack/webpack/issues/11613)### [`v2.0.2`](https://togithub.com/microsoft/tslib/releases/tag/2.0.2):ES Module Support[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.1...2.0.2)This release adds support for using tslib in Node using esmoduleimports, further context in[#​126](https://togithub.com/Microsoft/tslib/issues/126) and therelated issues.### [`v2.0.1`](https://togithub.com/microsoft/tslib/releases/tag/2.0.1):Minor release for TS 4.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.0...2.0.1)1. Use Object.prototype.hasOwnProperty.call.2. Skip default when iterating exports in \__importStar.3. Shorter parameter name in \__exportStar.### [`v2.0.0`](https://togithub.com/microsoft/tslib/releases/tag/2.0.0):tslib 2.0.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/v1.14.1...2.0.0)This release changes `__exportStar` and `__importStar` to use`__createBinding` which is incompatible with versions of TypeScriptolder than 3.9 (i.e. 3.8 and below).</details>---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbImNob3JlIiwiZGVwZW5kZW5jaWVzIl19-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
calcite-admin referenced this pull request in Esri/calcite-design-systemJul 30, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [tslib](https://www.typescriptlang.org/)([source](https://togithub.com/Microsoft/tslib)) | [`2.6.2` ->`2.6.3`](https://renovatebot.com/diffs/npm/tslib/1.14.1/2.6.3) |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>Microsoft/tslib (tslib)</summary>### [`v2.6.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.3)[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.6.2...v2.6.3)#### What's Changed- 'await using' normative changes by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/258](https://togithub.com/microsoft/tslib/pull/258)**Full Changelog**:microsoft/tslib@v2.6.2...v2.6.3###[`v2.6.2`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.2):tslib 2.6.2[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.6.1...v2.6.2)#### What's Changed- Fix path to `exports["module"]["types"]` by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/217](https://togithub.com/microsoft/tslib/pull/217)**Full Changelog**:microsoft/tslib@v2.6.1...v2.6.2###[`v2.6.1`](https://togithub.com/microsoft/tslib/releases/tag/v2.6.1):tslib 2.6.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.6.0...v2.6.1)#### What's Changed- Allow functions as values in \__addDisposableResource by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/215](https://togithub.com/microsoft/tslib/pull/215)- Stop using es6 syntax in the es6 file by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/216](https://togithub.com/microsoft/tslib/pull/216)**Full Changelog**:microsoft/tslib@2.6.0...v2.6.1### [`v2.6.0`](https://togithub.com/microsoft/tslib/releases/tag/2.6.0):tslib 2.6.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/v2.5.3...2.6.0)#### What's Changed- Add helpers for `using` and `await using` by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/213](https://togithub.com/microsoft/tslib/pull/213)**Full Changelog**:microsoft/tslib@v2.5.3...2.6.0###[`v2.5.3`](https://togithub.com/microsoft/tslib/releases/tag/v2.5.3):tslib 2.5.3[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.2...v2.5.3)#### What's Changed- Do not reference tslib.es6.js from package.json exports by[@​andrewbranch](https://togithub.com/andrewbranch) in[https://github.com/microsoft/tslib/pull/208](https://togithub.com/microsoft/tslib/pull/208)**Full Changelog**:microsoft/tslib@2.5.2...v2.5.3### [`v2.5.2`](https://togithub.com/microsoft/tslib/releases/tag/2.5.2):tslib 2.5.2[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.1...2.5.2)This release [explicitly re-exportshelpers](https://togithub.com/microsoft/tslib/pull/204) to work aroundTypeScript's incomplete symbol resolution for tslib.### [`v2.5.1`](https://togithub.com/microsoft/tslib/releases/tag/2.5.1):tslib 2.5.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.5.0...2.5.1)This release of tslib provides fixes for two issues.First, [it reverses the order of `init` hooks provided bydecorators](https://togithub.com/microsoft/tslib/pull/202) to correctlyreflect proposed behavior.Second, it [corrects the `exports` field of tslib's `package.json` andprovides accurate declarationfiles](https://togithub.com/microsoft/tslib/pull/202) so that it may beconsumed under the `node16` and `bundler` settings for`moduleResolution.`### [`v2.5.0`](https://togithub.com/microsoft/tslib/releases/tag/2.5.0):tslib 2.5.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.4.1...2.5.0)#### What's New- Fix asyncDelegator reporting done too early by[@​apendua](https://togithub.com/apendua) in[https://github.com/microsoft/tslib/pull/187](https://togithub.com/microsoft/tslib/pull/187)- Add support for TypeScript 5.0's `__esDecorate` and related helpers by[@​rbuckton](https://togithub.com/rbuckton) in[https://github.com/microsoft/tslib/pull/193](https://togithub.com/microsoft/tslib/pull/193)**Full Changelog**:microsoft/tslib@2.4.1...2.5.0### [`v2.4.1`](https://togithub.com/microsoft/tslib/releases/tag/2.4.1):tslib 2.4.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.4.0...2.4.1)This release contains [fixes for early `return`s and `throw`s invoked ongenerators](https://togithub.com/microsoft/tslib/pull/186).### [`v2.4.0`](https://togithub.com/microsoft/tslib/releases/tag/2.4.0):tslib 2.4.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.3.1...2.4.0)This release includes the `__classPrivateFieldIn` helper as well as anupdate to `__createBinding` to reduce indirection between multiplere-exports.### [`v2.3.1`](https://togithub.com/microsoft/tslib/releases/tag/2.3.1):tslib 2.3.1[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1)This release updates the `__spreadArray` helper for TypeScript 4.4 tocorrectly operate on collections that are not "concat-spreadable" suchas the DOM's `NodeList`s and `HTMLCollection`s.### [`v2.3.0`](https://togithub.com/microsoft/tslib/releases/tag/2.3.0):tslib 2.3.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0)This release updates tslib to use TypeScript 4.4's upcoming`__spreadArray` helper which correctly preserves sparse array inputs(e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This newversion of `__spreadArray` is backwards-compatible and is often alsofaster. See[https://github.com/microsoft/tslib/pull/151](https://togithub.com/microsoft/tslib/pull/151)for more details.### [`v2.2.0`](https://togithub.com/microsoft/tslib/releases/tag/2.2.0):tslib 2.2.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0)This release supports TypeScript 4.3's new functionality for ECMAScriptprivate methods and accessors, and private static class members.It does so by expanding the scope of `__classPrivateFieldGet` and`__classPrivateFieldSet`. See[https://github.com/microsoft/tslib/pull/146](https://togithub.com/microsoft/tslib/pull/146)for more details.### [`v2.1.0`](https://togithub.com/microsoft/tslib/releases/tag/2.1.0):tslib 2.1.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.3...2.1.0)This release adds a new `__spreadArray` helper which avoids side-effectscompared to the now-deprecated `__spreadArrays` and `__spread` helpers.See[https://github.com/microsoft/tslib/pull/133](https://togithub.com/microsoft/tslib/pull/133)for more details.This release also provides a more-specific error message when extendingfrom a type which is not a function and not null. See[https://github.com/microsoft/tslib/pull/138](https://togithub.com/microsoft/tslib/pull/138)for more details.### [`v2.0.3`](https://togithub.com/microsoft/tslib/releases/tag/2.0.3):Webpack 5 Compatibility - 2.x[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.2...2.0.3)Full discussion in the [webpackissue](https://togithub.com/webpack/webpack/issues/11613)### [`v2.0.2`](https://togithub.com/microsoft/tslib/releases/tag/2.0.2):ES Module Support[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.1...2.0.2)This release adds support for using tslib in Node using esmoduleimports, further context in[#​126](https://togithub.com/Microsoft/tslib/issues/126) and therelated issues.### [`v2.0.1`](https://togithub.com/microsoft/tslib/releases/tag/2.0.1):Minor release for TS 4.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/2.0.0...2.0.1)1. Use Object.prototype.hasOwnProperty.call.2. Skip default when iterating exports in \__importStar.3. Shorter parameter name in \__exportStar.### [`v2.0.0`](https://togithub.com/microsoft/tslib/releases/tag/2.0.0):tslib 2.0.0[CompareSource](https://togithub.com/Microsoft/tslib/compare/v1.14.1...2.0.0)This release changes `__exportStar` and `__importStar` to use`__createBinding` which is incompatible with versions of TypeScriptolder than 3.9 (i.e. 3.8 and below).</details>---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbImNob3JlIiwiZGVwZW5kZW5jaWVzIl19-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
__spreadArrayhelper to align withmicrosoft/TypeScript#44527