Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add x, y parameters to getBoundingClientRect#3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
TimothyGu merged 2 commits intojsdom:masterfromaekobear:master
Jun 19, 2021

Conversation

aekobear
Copy link
Contributor

@aekobearaekobear commentedMay 10, 2021
edited
Loading

getBoundingClientRect returns aDOMRect which is supposed to have anx andy property. This change makesgetBoundingClientRect behave more reliably for code which expects its properties to have defined numerical values.

fixes#3188

@domenic
Copy link
Member

Although the general plan for these not-very-good mocks is still up in the air (see#2751), this seems like a reasonable improvement assuming CI passes, so I'll merge it pending further discussion on that point.

@domenicdomenic self-assigned thisMay 22, 2021
@domenic
Copy link
Member

Looks like this requires a few test updates.

@domenicdomenic removed their assignmentMay 23, 2021
@aekobear
Copy link
ContributorAuthor

@domenic sorry for the delay on this- I had trouble getting tests to run locally.

I updated the "build" tests so they should pass now, but I couldn't figure out why "build-with-canvas" was failing with a segmentation fault. Let me know if this is expected, or if there is further action that needs to be done on my part.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TimothyGuTimothyGuTimothyGu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getBoundingClientRect is missing x, y parameters
3 participants
@aekobear@domenic@TimothyGu

[8]ページ先頭

©2009-2025 Movatter.jp