Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.7k
Add x, y parameters to getBoundingClientRect#3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Although the general plan for these not-very-good mocks is still up in the air (see#2751), this seems like a reasonable improvement assuming CI passes, so I'll merge it pending further discussion on that point. |
Looks like this requires a few test updates. |
@domenic sorry for the delay on this- I had trouble getting tests to run locally. I updated the "build" tests so they should pass now, but I couldn't figure out why "build-with-canvas" was failing with a segmentation fault. Let me know if this is expected, or if there is further action that needs to be done on my part. |
Uh oh!
There was an error while loading.Please reload this page.
getBoundingClientRect
returns aDOMRect which is supposed to have anx
andy
property. This change makesgetBoundingClientRect
behave more reliably for code which expects its properties to have defined numerical values.fixes#3188