- Notifications
You must be signed in to change notification settings - Fork242
Set up lint and test#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As it's not an externally used lib flow isn't too important to me, and without flow then it doesn't need babel 👍
pre-commit with Prettier is a big 👍 for me
Travis is used on some of the others?
I don't have strong opinions - it's still actively supported by node though
|
SimenB commentedNov 8, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok, made those changes. Tests are failing on node 4 with a really useless error. One issue with not dropping node 4 is that we won't be able to upgrade jest. Not a huge issue, I guess 🙂 EDIT: Stupid error. Actually running it on node made it obvious, not sure why the error thrown by jest (via |
| yarn: true | ||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
geez, I love Travis config being so simple compared to Circle 2
| }, | ||
| "prettier": { | ||
| "singleQuote": true, | ||
| "trailingComma": "all" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
add"bracketSpacing": false maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do you prefer it? Seems like a fb-ism. Happy to add, of course, I don't really care as long as it's formatted for me :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have no preference, just that the diff would be smaller :D. We can scratch that
#yolo |
Uh oh!
There was an error while loading.Please reload this page.
Not sure what we want here, so I just threw together something that works.
Other: