Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[chore] upgrades html-minifier-terser@5.0.0 -> 6.0.2#1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

gabrielcsapo
Copy link
Contributor

Summary

fixes#1687.

Updates the snapshots to reflect the terser upgrade.

@gabrielcsapogabrielcsapo marked this pull request as draftSeptember 29, 2021 20:21
@gabrielcsapogabrielcsapo marked this pull request as ready for reviewSeptember 29, 2021 20:39
@gabrielcsapo
Copy link
ContributorAuthor

@jantimon I will have a follow up PR to make these fixtures snapshots as this would have been easier to runjest -u instead of having to update the fixtures manually if that okay with you?

@jantimon
Copy link
Owner

You can rebuild all examples withnpm run rebuild-examples

Snapshots are way harder to read

gabrielcsapo reacted with thumbs up emoji

@gabrielcsapo
Copy link
ContributorAuthor

I will run that to make sure I got everything!@jantimon

Is there anything else I should do before we can merge?

Copy link
Owner

@jantimonjantimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't need async await to return the promise.
Can you please revert those two changes?

@jantimon
Copy link
Owner

@gabrielcsapo did you already have time to look into my feedback? :)

gabrielcsapoand others added3 commitsOctober 9, 2021 10:23
Co-authored-by: Jan Nicklas <j.nicklas@me.com>
Co-authored-by: Jan Nicklas <j.nicklas@me.com>
@gabrielcsapo
Copy link
ContributorAuthor

@jantimon just updated the PR based on the feedback.

@gabrielcsapo
Copy link
ContributorAuthor

@jantimon kindly bumping this.

@jantimonjantimon merged commit16a841a intojantimon:mainOct 15, 2021
@jantimon
Copy link
Owner

thanks@gabrielcsapo

@jantimon
Copy link
Owner

released as 5.4.0

@jantimon
Copy link
Owner

@gabrielcsapo your changes break the build pipelines - could you please take a look what’s wrong?

@gabrielcsapo
Copy link
ContributorAuthor

gabrielcsapo commentedOct 16, 2021 via email

Yes, I’ll check today.
On Sat, Oct 16, 2021 at 1:42 AM Jan Nicklas ***@***.***> wrote:@gabrielcsapo <https://github.com/gabrielcsapo> your changes break the build pipelines - could you please take a look what’s wrong? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1688 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOE2WYFTRFGWVZ2ILABIOLUHE3ITANCNFSM5FAXH7LA> .
jantimon and slorber reacted with heart emoji

@gabrielcsapogabrielcsapo deleted the gabrielcsapo/upgrade-html-minifier-terser branchOctober 16, 2021 16:41
@gabrielcsapo
Copy link
ContributorAuthor

@jantimon there seems to be a race condition with checking the contents of the files on disk and starting a new test. It might make sense to have each test output to a specific directory on disk to avoid collisions. I am not seeing this same issue locally, so it will be hard to debug to be for sure.

Another option is using snapshots as they are in memory and won't have collision issues.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jantimonjantimonAwaiting requested review from jantimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Terser 5 + html-minifier-terser 6
2 participants
@gabrielcsapo@jantimon

[8]ページ先頭

©2009-2025 Movatter.jp