- Notifications
You must be signed in to change notification settings - Fork2k
Skip sending the proxyReq event when the expect header is present#1447
Skip sending the proxyReq event when the expect header is present#1447
Conversation
Uh oh!
There was an error while loading.Please reload this page.
alexgvozden commentedMay 17, 2020
will anyone merge this if it solves the issue? |
amitmula commentedMay 17, 2020
Any ETA on when this is getting merged ? |
Hypnosphi commentedMay 17, 2020
@indexzero@jcrugzz looks like this requires your immediate attention |
indexzero commentedMay 17, 2020
My children are the only thing that requires immediate attention, sorry. Software happens during normal working hours. Didn't get to this on Friday, therefore it will be tomorrow. Jarrett may have a moment, I have asked him. |
jcrugzz commentedMay 17, 2020
@jsmylnycky thanks for the work here. Will release this fix in a few |
jcrugzz commentedMay 17, 2020
published as |
fabb commentedMay 18, 2020
Have you informed npm support to whitelist this version? Currently it‘s still blacklisted:https://www.npmjs.com/advisories/1486/versions |
Hypnosphi commentedMay 18, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@indexzero that's understandable, sorry for my wording. But thevulnerability seems reported almost 3 months ago. Do you consider adding more core maintainers as an option? |
jsmylnycky commentedMay 18, 2020
@Hypnosphi If you take a look at the top of the Issues page, there's two pinned posts going back to Aug/Sept, basically looking to get more people active with the future of this project. There's been very little activity from folks willing to actually jump in and contribute tho. If it is something you're interested in doing, I suggest you take a look at those posts and leave some comments to get in touch :) |
Lucidiot commentedMay 18, 2020
Just out of curiosity, was the vulnerabilityactually reported to the maintainers? This would not be the first time nobody knows about the issue until the advisory goes public:sass/node-sass#2816 (comment) |
hendrikmolder commentedMay 18, 2020
They've now marked the fixed version as unaffected |
Uh oh!
There was an error while loading.Please reload this page.
Hotfix forhttps://www.npmjs.com/advisories/1486
Expecting build error due to Node 6. Waiting for#1397 to be merged to have a clean CI build.