Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove Setup-Go#403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SVilgelm merged 4 commits intomasterfromremove_setup_go
Feb 24, 2022
Merged

Remove Setup-Go#403

SVilgelm merged 4 commits intomasterfromremove_setup_go
Feb 24, 2022

Conversation

StevenACoffman
Copy link
Contributor

@StevenACoffmanStevenACoffman commentedFeb 24, 2022•
edited
Loading

Per discussion in#365, this removessetup-go dep.

Until this PR is landed, we are stuck and unable to upgrade any dependencies, fix any vulns, due to the inability to build thesetup-go package.

So now we remove it and then we will need to explicitly install go, like:

steps:      -uses:actions/checkout@v2      -uses:actions/setup-go@v2# <-- here      -name:golangci-lintuses:golangci/golangci-lint-action@v2

Of course, it will then require us to bump v3, but I imagine there are further documentation changes required so I am not doing that in this PR.

Signed-off-by: Steve Coffmansteve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@SVilgelm
Copy link
Member

Thank you very much for this PR, it looks good to me. Just one note: please update all examples in readme, add the go installation step. I need few day for testing.

@kamilskkamilsk self-requested a reviewFebruary 24, 2022 10:48
@kamilsk
Copy link
Contributor

great

Copy link
Member

@SVilgelmSVilgelm left a comment•
edited by StevenACoffman
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • add go installation step in all examples in the README.md file
  • remove skip-go-installation option from action.yml and from README.md files
  • Add a note in the readme that v3 requires explicit go installation step

@SVilgelm
Copy link
Member

Here is the PR I use for testing the changes for this action:sv-tools/mongoifc#49
everything works fine so far

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
ContributorAuthor

StevenACoffman commentedFeb 24, 2022•
edited
Loading

I think I have now corrected the references you mention, but please let me know if additional references to setup-go are present, or if I should make any further edits.

@magnetikonline
Copy link

Thanks for doing this work@StevenACoffman - great to see it finally in the new@v3 action. 👍

StevenACoffman and bwinter reacted with heart emoji

jzelinskie added a commit to authzed/actions that referenced this pull requestApr 11, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SVilgelmSVilgelmSVilgelm approved these changes

@kamilskkamilskAwaiting requested review from kamilsk

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@StevenACoffman@SVilgelm@kamilsk@magnetikonline@ldez
[8]ページ先頭
©2009-2025 Movatter.jp