Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.9k
Update: Add enforceForIndexOf option to use-isnan (fixes #12207)#12379
Merged
platinumazure merged 2 commits intomasterfromOct 25, 2019
Merged
Update: Add enforceForIndexOf option to use-isnan (fixes #12207)#12379platinumazure merged 2 commits intomasterfrom
platinumazure merged 2 commits intomasterfrom
Conversation
platinumazure approved these changesOct 20, 2019
Member
platinumazure commentedOct 20, 2019
This looks good to me, but I'll leave it open another day or two in case other team members want to review. Sorry for letting this slip through the cracks. |
This was referencedNov 9, 2019
This was referencedMar 11, 2020
This was referencedMar 26, 2020
This was referencedApr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusion archived due to ageThis issue has been archived; please open a new issue for any further discussion enhancementThis change enhances an existing feature of ESLint ruleRelates to ESLint's core rules
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule#12207
Examples ofincorrect code for this rule with
"enforceForIndexOf"option set totrue:What changes did you make? (Give an overview)
New option
enforceForIndexOfin theuse-isnanrule.Is there anything you'd like reviewers to focus on?
It seemed too complex to have an advice in the message since it depends on whether the user wants to find index or just check for existence, and also what environments are available. There are examples in the docs for different environments.