Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
[WIP] Finish initial SSR (server side rendering) and add tests.#1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This takes a string input, and converts it into a fully-qualified URL. For example, `./foo` becomes `http://example.com/current/path/foo`. Then we can compare it to other fully-qualified `URL` instances.
vercelbot commentedJun 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/2CFnWQmsbQ8UvXud3MuYLjBhAyDS |
codesandbox-cibot commentedJun 17, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit6be2965:
|
| expect(isExternal('//google.com/foo.md')).to.be.true; | ||
| expect(isExternal('/google.com/foo.md')).to.be.false; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't get to circle back to this yet, but it is high on my priority list. These tests are the important part, so we know it is working well.
e5d8ecc tobb1e84aComparebb1e84a to6be2965Comparetest/unit/server.test.js Outdated
| await renderer.renderToString('/changelog'); | ||
| expect(renderer).to.be.an.instanceof(Renderer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TODO, server tests here
anikethsaha left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this independent of#1276 ?
Also, if its still in WIP, can you convert this into draft.
* develop: (81 commits) fix: upgrade dompurify from 2.1.0 to 2.1.1 (#1402) fix: upgrade dompurify from 2.0.17 to 2.1.0 (#1397) fix: search on homepage test (#1398) fix: the sidebar links to another site. (#1336) fix: Can't search homepage content (#1391) fix: upgrade debug from 4.1.1 to 4.3.0 (#1390) fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1389) Fix eslint warnings (#1388) docs: add crossOriginLinks configurations details. (#1386) Remove Cypress screenshots Fix friendly message display Add Vue 3 compatibility Show dir listing & help msg for manual instance Add NODE_MODULES_URL global Jest + Playwright Testing (#1276) update doc (#1381) Fix scroll event end value fix: upgrade docsify from 4.11.4 to 4.11.6 (#1373) chore(deps): bump node-fetch in /packages/docsify-server-renderer (#1370) test: fix cannot search list content (#1367) ...
44f8a8d to607ccc6Comparegpetrov commentedJan 13, 2021
any progress on this? We would really like to get SSR working |
…to specifically use .cjs (those tools don't support Node ESM files yet), use a single eslintrc file, all test code uses ESM import/export syntax instead of require (WIP)
607ccc6 to27b2e32Compare* develop: (104 commits) chore: bump ssri from 6.0.1 to 6.0.2 (#1563) chore: Update Edit Document using develop branch (#1541) fix: Add escapeHtml for search (#1551) docs: link with plugin Pagination (#1554) fix: Upgrade dompurify from 2.2.6 to 2.2.7 (#1553) fix: upgrade dompurify from 2.2.6 to 2.2.7 (#1552) chore: bump y18n from 4.0.0 to 4.0.1 (#1548) chore: Fix search for missing pathNamespaces (#1547) fix: Upgrade docsify from 4.12.0 to 4.12.1 (#1544) docs:Update deploy, change Zeit to Vercel (#1540) fix: Cannot read property 'classList' of null (#1527) chore: fix microsoft/playwright-github-action error (#1534) Update PULL_REQUEST_TEMPLATE.md chore: Update CHANGELOG and Update test snapshots chore: add changelog 4.12.1 [build] 4.12.1 feat: Support search when there is no title (#1519) test(unit): add test cases on isExternal. (#1515) docs: Update Vercel logo link (#1520) fix: Upgrade docsify from 4.11.6 to 4.12.0 (#1518) ...
…erly fail so much, and log errors to console instead of swallowing them
Many things work. What doesn't work (needs work):- Any dynamic config options (f.e. any that use functions) need to be specified in the HTML by augmenting the injected config object. This includes plugins, Vue components, and similar.- Plugins and Vue don't work on initial SSR render. Switch pages dynamically and they work during the dynamic markdown handling.- Cover page causes an error- Search plugin causes an error
trusktr commentedMay 18, 2021
I just pushed a working concept! The commit describes a few things that don't work, but for basic without plugins or Vue components it will work. Up next we need to figure how to handle plugins, and Vue components (@jhildenbiddle). We need to call some parts of plugins during SSR markdown handling, and other parts of plugins on the client side where they can control the resulting DOM. Search and cover page aren't working (they have some URL mis-handling, similar to what I fixed in this PR in other areas of the code, just needs some more work. Next time!). |
trusktr commentedMay 21, 2021
I made an update to the title to better reflect what this has become (finishing the initial SSR implementation). A side-effect of it is adding tests for some features (that was the original intent of the PR). |
Uh oh!
There was an error while loading.Please reload this page.
Summary
Moved fromanikethsaha#3
Expands on stuff from#1128 (this PR includes those changes) whichfixes#1126.
This will PR do the following (WIP):
replaces custom URL analysis (custom regex) with DOM APIs that are known to work in
isExternaladds tests for it
fixes SSR because
isExternalis used there, and to test it there we must fix it (one line fix)adds tests for SSR now that it is fixed
uses DOM APIs (JSDOM in Node.js and SSR, otherwise native APIs) for the
isExternalfunctionconsolidate
isExternalso all code imports the same versioninitial tests for server-renderer (WIP, we can't test DOMPurify in SSR if SSR isn't working, so first we get SSR working and add a simple test for it)
add tests for isExternal and DOMPurify (WIP)
cleanup (remove comments, use conventional commit messages, etc)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)#1126
You have tested in the following browsers: (Providing a detailed version will be better.)